public inbox for
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <>
Cc: gcc-patches <>
Subject: Re: [PATCH, rs6000] Add two peephole2 patterns for mr. insn
Date: Mon, 19 Jun 2023 20:07:04 -0400 (EDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, 30 May 2023, HAO CHEN GUI via Gcc-patches wrote:

> +++ b/gcc/config/rs6000/
> @@ -7891,6 +7891,36 @@ (define_insn "*mov<mode>_internal2"
>     (set_attr "dot" "yes")
>     (set_attr "length" "4,4,8")])
> +(define_peephole2
> +  [(set (match_operand:CC 2 "cc_reg_operand" "")
> +	(compare:CC (match_operand:P 1 "int_reg_operand" "")
> +		    (const_int 0)))
> +   (set (match_operand:P 0 "int_reg_operand" "")

A random comment from the sideline: I'd suggest to remove the 
(empty) constraints string from your peephole2's.

It can be a matter of port-specific-taste but it seems removing 
them would be consistent with the other peephole2's in

(In this matter, I believe the examples in md.texi are bad.)

brgds, H-P

  parent reply	other threads:[~2023-06-20  0:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30  6:32 HAO CHEN GUI
2023-06-06  9:29 ` Kewen.Lin
2023-06-20  0:07 ` Hans-Peter Nilsson [this message]
2023-06-20  3:03   ` HAO CHEN GUI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).