From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id 1CDF83858C2C for ; Sun, 9 Jul 2023 21:58:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CDF83858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com Received: by arjuna.pair.com (Postfix, from userid 3006) id C0ED88A7D9; Sun, 9 Jul 2023 17:58:36 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id C02E08A7D7; Sun, 9 Jul 2023 17:58:36 -0400 (EDT) Date: Sun, 9 Jul 2023 17:58:36 -0400 (EDT) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Manolis Tsamis cc: gcc-patches@gcc.gnu.org, Richard Biener , Philipp Tomsich , Jeff Law Subject: Re: [PATCH v2] Implement new RTL optimizations pass: fold-mem-offsets. In-Reply-To: Message-ID: References: <20230615172817.3587006-1-manolis.tsamis@vrull.eu> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.11 on 209.68.5.131 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 9 Jul 2023, Hans-Peter Nilsson wrote: > On Thu, 15 Jun 2023, Manolis Tsamis wrote: > > > This is a new RTL pass that tries to optimize memory offset calculations > > by moving them from add immediate instructions to the memory loads/stores. > It punts on all "use" insns that are not SET. > Why not use single_set there too? Also, I don't see insn costs considered? (Also: typo "immidiate".) brgds, H-P