From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arjuna.pair.com (arjuna.pair.com [209.68.5.131]) by sourceware.org (Postfix) with ESMTPS id 228173858D33 for ; Fri, 24 May 2024 00:10:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 228173858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bitrange.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bitrange.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 228173858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.68.5.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716509422; cv=none; b=FTIW1ZJdIfCrFT4e1GoAPwvMFRin4sqoSav2PBRirZ21LlayL05o4k5CrmS0VTR63dHP4eOQsMP9kSOl3kwxI9hoWRSN+A0OB6SA4UrjHYSYmZReXXDqbH8NuCvG2/nLbjs1x2CMhKxz2CsAz27dms0KhtfGmG3HTe5M1H8U5KE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716509422; c=relaxed/simple; bh=C1pgPDVyHhT9Otb85qDfTrfGWe+n+g1VQ0NOA8v6hno=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=gvtX27R/XJJTNfH6WCgPGuK94Z+hNbhhQs7AFUf9fXAPfv63D0OrburjJBMmCf0rFn3CMkg8gMdE+ysjSMRDdy0a8wuDL3yOwf52aGUqHU2wdnNdLpHQmMztTuEJB30iSaM8zZWNqKsy62rEhFcQgpRLyjf5izFdtjfJvmFjW0s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by arjuna.pair.com (Postfix, from userid 3006) id 8C3848A89D; Thu, 23 May 2024 20:10:20 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by arjuna.pair.com (Postfix) with ESMTP id 8BC558A89B; Thu, 23 May 2024 20:10:20 -0400 (EDT) Date: Thu, 23 May 2024 20:10:20 -0400 (EDT) From: Hans-Peter Nilsson X-X-Sender: hp@arjuna.pair.com To: Jiufu Guo cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH V3] report message for operator %a on unaddressible operand In-Reply-To: <20240520052224.2583967-1-guojiufu@linux.ibm.com> Message-ID: References: <20240520052224.2583967-1-guojiufu@linux.ibm.com> User-Agent: Alpine 2.20.16 (BSF 172 2016-09-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.11 on 209.68.5.131 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 20 May 2024, Jiufu Guo wrote: > Hi, > > For PR96866, when printing asm code for modifier "%a", an addressable > operand is required. While the constraint "X" allow any kind of > operand even which is hard to get the address directly. e.g. extern > symbol whose address is in TOC. > An error message would be reported to indicate the invalid asm operand. > > Compare with previous version, code comments and message are updated. > > Bootstrap®test pass on ppc64{,le}. > Is this ok for trunk? > > BR, > Jeff(Jiufu Guo) > > PR target/96866 > > gcc/ChangeLog: > > * config/rs6000/rs6000.cc (print_operand_address): > > gcc/testsuite/ChangeLog: > > * gcc.target/powerpc/pr96866-1.c: New test. > * gcc.target/powerpc/pr96866-2.c: New test. The gcc/ChangeLog entry needs some text after that ":". brgds, H-P