From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Richard Sandiford <rdsandiford@googlemail.com>,
Steve Ellcey <sellcey@mips.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: MIPS tests (nan-legacy.c and nans-legacy.c) failing
Date: Tue, 13 Aug 2013 13:28:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1308130002260.8514@tp.orcam.me.uk> (raw)
In-Reply-To: <87fvul5k37.fsf@talisman.default>
On Wed, 7 Aug 2013, Richard Sandiford wrote:
> > When I run two of your new tests in gcc.target/mips (nan-legacy.c and
> > nans-legacy.c), they are failing because my GCC is putting out
> >
> > .word 4294967295
> >
> > instead of
> >
> > .word -1
> >
> > like the test is expecting.
> >
> > I believe they are equivalent (0xffffffff) but I am not sure what it
> > is about my targets (mips-mti-elf and mips-mti-linux-gnu) that would
> > make this different from yours. Should the tests be modified to allow
> > either output?
>
> Maciej, have you had chance to look at this yet?
I've had a look now and that is related to the width of `long' on the
host -- encode_ieee_double returns its output 32-bit bit patterns in a
buffer of signed longs. The arithmetic value of these patterns therefore
depends on whether the width of `long' is 32 bits or wider.
Here, in the case of nan-legacy.c, we have:
image_hi <- 0x7ff7ffff
image_lo <- 0xffffffff
so the returned pair of long values will be:
2146959359, -1
on a host where the width of `long' is 32 bits and:
2146959359, 4294967295
on a host where the width of `long' is 64 bits. Then when supplied as the
argument to the assembly-language .word pseudo-op, the two sets of values
produce the same bit patterns in the object file produced.
It's not clear to me if this dependency on the width of `long' is a bug
or feature, but a path-of-least-resistance fix is as follows.
This has passed mips-linux-gnu regression testing on a 32-bit host, but I
can't regression-test a 64-bit host easily -- Steve, can you please verify
that this change indeed works for you? Richard, OK to apply assuming that
it does?
2013-08-13 Maciej W. Rozycki <macro@codesourcery.com>
gcc/testsuite/
* gcc.target/mips/nan-legacy.c: Accept 4294967295 as an
alternative to -1.
* gcc.target/mips/nans-legacy.c: Likewise.
Maciej
gcc-mips-nan2008-test-fix.diff
Index: gcc-fsf-trunk-quilt/gcc/testsuite/gcc.target/mips/nan-legacy.c
===================================================================
--- gcc-fsf-trunk-quilt.orig/gcc/testsuite/gcc.target/mips/nan-legacy.c 2013-08-13 14:18:50.008738612 +0100
+++ gcc-fsf-trunk-quilt/gcc/testsuite/gcc.target/mips/nan-legacy.c 2013-08-13 14:22:49.568772451 +0100
@@ -4,4 +4,4 @@
double d = __builtin_nan ("");
/* { dg-final { scan-assembler "\t\\.nan\tlegacy\n" } } */
-/* { dg-final { scan-assembler "\t\\.word\t2146959359\n\t\\.word\t-1\n" } } */
+/* { dg-final { scan-assembler "\t\\.word\t2146959359\n\t\\.word\t(?:-1|4294967295)\n" } } */
Index: gcc-fsf-trunk-quilt/gcc/testsuite/gcc.target/mips/nans-legacy.c
===================================================================
--- gcc-fsf-trunk-quilt.orig/gcc/testsuite/gcc.target/mips/nans-legacy.c 2013-08-13 14:18:50.008738612 +0100
+++ gcc-fsf-trunk-quilt/gcc/testsuite/gcc.target/mips/nans-legacy.c 2013-08-13 14:22:49.568772451 +0100
@@ -4,4 +4,4 @@
double ds = __builtin_nans ("");
/* { dg-final { scan-assembler "\t\\.nan\tlegacy\n" } } */
-/* { dg-final { scan-assembler "\t\\.word\t2147483647\n\t\\.word\t-1\n" } } */
+/* { dg-final { scan-assembler "\t\\.word\t2147483647\n\t\\.word\t(?:-1|4294967295)\n" } } */
next prev parent reply other threads:[~2013-08-13 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 23:27 Steve Ellcey
2013-08-07 20:20 ` Richard Sandiford
2013-08-13 13:28 ` Maciej W. Rozycki [this message]
2013-08-13 16:49 ` Steve Ellcey
2013-08-13 17:25 ` Richard Sandiford
2013-08-13 21:53 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1308130002260.8514@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdsandiford@googlemail.com \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).