From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Matthew Fortune <Matthew.Fortune@imgtec.com>
Cc: "Moore, Catherine" <Catherine_Moore@mentor.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Eric Christopher <echristo@gmail.com>
Subject: RE: [PATCH] MIPS/GCC: Unconditional jump generation bug fix
Date: Wed, 19 Nov 2014 13:35:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1411191318260.2881@tp.orcam.me.uk> (raw)
In-Reply-To: <6D39441BF12EF246A7ABCE6654B0235320F73C2C@LEMAIL01.le.imgtec.org>
On Tue, 18 Nov 2014, Matthew Fortune wrote:
> > > I admit to being a bit more nervous about 4.9 but the test coverage
> > > seems thorough enough. I guess I would have been less concerned if the
> > > optimisation was still just tied to TARGET_MICROMIPS for the 4.9
> > branch.
> > >
> > > Catherine, what do you think?
> > >
> > This is okay for 4.9 IMO.
>
> OK
FWIW we've been using this change since Oct 2012 with no issues (as I
noted it was meant to be included with the original microMIPS support
submission, but was lost in transit) and also GAS has code to relax
out-of-range branches to jumps in non-PIC standard MIPS code under the
same condition this RTL insn uses, so even if a wrong branch slipped
through here (which it doesn't), then GAS would fix it up.
See gas/config/tc-mips.c (md_apply_fix) <BFD_RELOC_16_PCREL_S2> for the
relaxation piece if interested.
Maciej
next prev parent reply other threads:[~2014-11-19 13:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 16:38 Maciej W. Rozycki
2014-11-17 16:56 ` Matthew Fortune
2014-11-18 16:56 ` Maciej W. Rozycki
2014-11-18 17:28 ` Matthew Fortune
2014-11-18 17:29 ` Moore, Catherine
2014-11-18 19:33 ` Matthew Fortune
2014-11-19 13:35 ` Maciej W. Rozycki [this message]
2014-12-05 10:48 ` Richard Sandiford
2014-12-05 11:06 ` Matthew Fortune
2014-12-05 11:25 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1411191318260.2881@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=Catherine_Moore@mentor.com \
--cc=Matthew.Fortune@imgtec.com \
--cc=echristo@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).