public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: <gcc-patches@gcc.gnu.org>
Cc: Paolo Bonzini <bonzini@gnu.org>
Subject: [PATCH] optabs.c: Update inline documentation
Date: Mon, 12 Sep 2016 14:40:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1609121510080.29007@tp.orcam.me.uk> (raw)

Hi,

 I've noticed commit 147425 ("cond-optab merge target-independent bits"), 
<https://gcc.gnu.org/ml/gcc-patches/2009-04/msg01030.html>, changed the 
semantics of `prepare_cmp_insn' function arguments, however did not fully 
accordingly update its documentation comment.  Here's the missing update.

	gcc/
	* optabs.c (prepare_cmp_insn): Update documentation comment.

 OK to apply?

  Maciej

gcc-optabs-prepare-cmp-insn-doc.diff
Index: gcc/gcc/optabs.c
===================================================================
--- gcc.orig/gcc/optabs.c	2016-08-15 17:24:21.124480231 +0100
+++ gcc/gcc/optabs.c	2016-08-15 17:42:29.370598925 +0100
@@ -3716,13 +3716,17 @@ can_compare_p (enum rtx_code code, machi
 }
 
 /* This function is called when we are going to emit a compare instruction that
-   compares the values found in *PX and *PY, using the rtl operator COMPARISON.
+   compares the values found in X and Y, using the rtl operator COMPARISON.
 
-   *PMODE is the mode of the inputs (in case they are const_int).
-   *PUNSIGNEDP nonzero says that the operands are unsigned;
+   If they have mode BLKmode, then SIZE specifies the size of both operands.
+
+   UNSIGNEDP nonzero says that the operands are unsigned;
    this matters if they need to be widened (as given by METHODS).
 
-   If they have mode BLKmode, then SIZE specifies the size of both operands.
+   *PTEST is where the resulting comparison RTX is returned or NULL_RTX
+   if we failed to produce one.
+
+   *PMODE is the mode of the inputs (in case they are const_int).
 
    This function performs all the setup necessary so that the caller only has
    to emit a single comparison insn.  This setup can involve doing a BLKmode

             reply	other threads:[~2016-09-12 14:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 14:40 Maciej W. Rozycki [this message]
2016-09-12 15:55 ` Jeff Law
2016-09-13 10:26   ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1609121510080.29007@tp.orcam.me.uk \
    --to=macro@imgtec.com \
    --cc=bonzini@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).