From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37855 invoked by alias); 12 Sep 2016 14:37:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 37839 invoked by uid 89); 12 Sep 2016 14:37:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:orig, *py X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Sep 2016 14:37:33 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id 13528CEB29E94; Mon, 12 Sep 2016 15:37:17 +0100 (IST) Received: from [10.20.78.177] (10.20.78.177) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Mon, 12 Sep 2016 15:37:19 +0100 Date: Mon, 12 Sep 2016 14:40:00 -0000 From: "Maciej W. Rozycki" To: CC: Paolo Bonzini Subject: [PATCH] optabs.c: Update inline documentation Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2016-09/txt/msg00631.txt.bz2 Hi, I've noticed commit 147425 ("cond-optab merge target-independent bits"), , changed the semantics of `prepare_cmp_insn' function arguments, however did not fully accordingly update its documentation comment. Here's the missing update. gcc/ * optabs.c (prepare_cmp_insn): Update documentation comment. OK to apply? Maciej gcc-optabs-prepare-cmp-insn-doc.diff Index: gcc/gcc/optabs.c =================================================================== --- gcc.orig/gcc/optabs.c 2016-08-15 17:24:21.124480231 +0100 +++ gcc/gcc/optabs.c 2016-08-15 17:42:29.370598925 +0100 @@ -3716,13 +3716,17 @@ can_compare_p (enum rtx_code code, machi } /* This function is called when we are going to emit a compare instruction that - compares the values found in *PX and *PY, using the rtl operator COMPARISON. + compares the values found in X and Y, using the rtl operator COMPARISON. - *PMODE is the mode of the inputs (in case they are const_int). - *PUNSIGNEDP nonzero says that the operands are unsigned; + If they have mode BLKmode, then SIZE specifies the size of both operands. + + UNSIGNEDP nonzero says that the operands are unsigned; this matters if they need to be widened (as given by METHODS). - If they have mode BLKmode, then SIZE specifies the size of both operands. + *PTEST is where the resulting comparison RTX is returned or NULL_RTX + if we failed to produce one. + + *PMODE is the mode of the inputs (in case they are const_int). This function performs all the setup necessary so that the caller only has to emit a single comparison insn. This setup can involve doing a BLKmode