From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80259 invoked by alias); 12 Sep 2016 14:15:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76361 invoked by uid 89); 12 Sep 2016 14:15:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=GMP, MPC, outright, exhaustive X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Sep 2016 14:15:05 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id 354A87990D42D; Mon, 12 Sep 2016 15:14:49 +0100 (IST) Received: from [10.20.78.177] (10.20.78.177) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Mon, 12 Sep 2016 15:14:51 +0100 Date: Mon, 12 Sep 2016 14:37:00 -0000 From: "Maciej W. Rozycki" To: Bernd Edlinger CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] Indicate minimum in-tree MPFR version handled In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2016-09/txt/msg00630.txt.bz2 On Fri, 12 Aug 2016, Bernd Edlinger wrote: > > + # MPFR v3.1.0 moved the sources into a src sub-directory. > > + if ! test -d ${srcdir}/mpfr/src; then > > + as_fn_error "Building GCC with MPFR in the source tree is only handled for MPFR 3.1.0+." "$LINENO" 5 > > + fi > > I think it is a good idea to detect this situation, but you should advise the user > that he has to use exactly the same version(s) that contrib/download_prerequisites > installs. We're not doing an exhaustive check for the GMP/MPFR/MPC dependencies here, so I think it's enough to point out the outright incompatibility. It might make sense though to have an additional check in the component requiring these libraries and issue a warning if a mismatch is detected with in-tree versions. Maciej