From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28204 invoked by alias); 2 Aug 2012 12:48:29 -0000 Received: (qmail 28195 invoked by uid 22791); 2 Aug 2012 12:48:28 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail4-relais-sop.national.inria.fr (HELO mail4-relais-sop.national.inria.fr) (192.134.164.105) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Aug 2012 12:48:10 +0000 Received: from stedding.saclay.inria.fr ([193.55.250.194]) by mail4-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 02 Aug 2012 14:48:09 +0200 Received: from glisse (helo=localhost) by stedding.saclay.inria.fr with local-esmtp (Exim 4.80) (envelope-from ) id 1Swuoy-0001qx-QA; Thu, 02 Aug 2012 14:48:08 +0200 Date: Thu, 02 Aug 2012 12:48:00 -0000 From: Marc Glisse To: Richard Guenther cc: gcc-patches@gcc.gnu.org Subject: Re: ORDERED_EXPR in invert_tree_comparison In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="935445242-634381134-1343911688=:7013" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-08/txt/msg00095.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --935445242-634381134-1343911688=:7013 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Content-length: 1050 On Thu, 2 Aug 2012, Richard Guenther wrote: > On Wed, Aug 1, 2012 at 9:21 PM, Marc Glisse wrote: >> Hello, >> >> an opinion on this? >> >> (I just noticed: I'll update the list in the comment visible at the top of >> the patch if this gets in). > > It looks ok to me but I am no floating-point expert. Can you add a testcase? > > Ok with that change. Here again with a testcase. The -O is not necessary for the optimization to happen, but it seemed wrong to me not to include it. I wondered about adding an explicit -ftrapping-math, for documentation purposes. I am redoing the bootstrap+regtest, then I'll commit if I don't hear protests about the testcase. gcc/ChangeLog 2012-06-15 Marc Glisse PR tree-optimization/53805 * fold-const.c (invert_tree_comparison): Do invert ORDERED_EXPR and UNORDERED_EXPR for floating point. gcc/testsuite/ChangeLog 2012-06-15 Marc Glisse PR tree-optimization/53805 * gcc.dg/fold-notunord.c: New testcase. -- Marc Glisse --935445242-634381134-1343911688=:7013 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=p7 Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: inline; filename=p7 Content-length: 2676 SW5kZXg6IGdjYy90ZXN0c3VpdGUvZ2NjLmRnL2ZvbGQtbm90dW5vcmQuYw0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIGdjYy90ZXN0c3VpdGUvZ2Nj LmRnL2ZvbGQtbm90dW5vcmQuYwkocmV2aXNpb24gMCkNCisrKyBnY2MvdGVz dHN1aXRlL2djYy5kZy9mb2xkLW5vdHVub3JkLmMJKHJldmlzaW9uIDApDQpA QCAtMCwwICsxLDEwIEBADQorLyogeyBkZy1kbyBjb21waWxlIH0gKi8NCisv KiB7IGRnLW9wdGlvbnMgIi1PIC1mZHVtcC10cmVlLW9wdGltaXplZCIgfSAq Lw0KKw0KK2ludCBmIChkb3VibGUgZCkNCit7DQorICByZXR1cm4gIV9fYnVp bHRpbl9pc25hbiAoZCk7DQorfQ0KKw0KKy8qIHsgZGctZmluYWwgeyBzY2Fu LXRyZWUtZHVtcCAiIG9yZCAiICJvcHRpbWl6ZWQiIH0gfSAqLw0KKy8qIHsg ZGctZmluYWwgeyBjbGVhbnVwLXRyZWUtZHVtcCAib3B0aW1pemVkIiB9IH0g Ki8NCg0KUHJvcGVydHkgY2hhbmdlcyBvbjogZ2NjL3Rlc3RzdWl0ZS9nY2Mu ZGcvZm9sZC1ub3R1bm9yZC5jDQpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQpB ZGRlZDogc3ZuOmVvbC1zdHlsZQ0KICAgKyBuYXRpdmUNCkFkZGVkOiBzdm46 a2V5d29yZHMNCiAgICsgQXV0aG9yIERhdGUgSWQgUmV2aXNpb24gVVJMDQoN CkluZGV4OiBnY2MvZm9sZC1jb25zdC5jDQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09DQotLS0gZ2NjL2ZvbGQtY29uc3QuYwkocmV2aXNpb24gMTkwMDcxKQ0K KysrIGdjYy9mb2xkLWNvbnN0LmMJKHdvcmtpbmcgY29weSkNCkBAIC0yMDg3 LDI2ICsyMDg3LDI4IEBAIHN0YXRpYyB0cmVlDQogcGVkYW50aWNfbm9uX2x2 YWx1ZV9sb2MgKGxvY2F0aW9uX3QgbG9jLCB0cmVlIHgpDQogew0KICAgaWYg KHBlZGFudGljX2x2YWx1ZXMpDQogICAgIHJldHVybiBub25fbHZhbHVlX2xv YyAobG9jLCB4KTsNCiANCiAgIHJldHVybiBwcm90ZWN0ZWRfc2V0X2V4cHJf bG9jYXRpb25fdW5zaGFyZSAoeCwgbG9jKTsNCiB9DQogDA0KIC8qIEdpdmVu IGEgdHJlZSBjb21wYXJpc29uIGNvZGUsIHJldHVybiB0aGUgY29kZSB0aGF0 IGlzIHRoZSBsb2dpY2FsIGludmVyc2UuDQogICAgSXQgaXMgZ2VuZXJhbGx5 IG5vdCBzYWZlIHRvIGRvIHRoaXMgZm9yIGZsb2F0aW5nLXBvaW50IGNvbXBh cmlzb25zLCBleGNlcHQNCi0gICBmb3IgRVFfRVhQUiBhbmQgTkVfRVhQUiwg c28gd2UgcmV0dXJuIEVSUk9SX01BUksgaW4gdGhpcyBjYXNlLiAgKi8NCisg ICBmb3IgRVFfRVhQUiwgTkVfRVhQUiwgT1JERVJFRF9FWFBSIGFuZCBVTk9S REVSRURfRVhQUiwgc28gd2UgcmV0dXJuDQorICAgRVJST1JfTUFSSyBpbiB0 aGlzIGNhc2UuICAqLw0KIA0KIGVudW0gdHJlZV9jb2RlDQogaW52ZXJ0X3Ry ZWVfY29tcGFyaXNvbiAoZW51bSB0cmVlX2NvZGUgY29kZSwgYm9vbCBob25v cl9uYW5zKQ0KIHsNCi0gIGlmIChob25vcl9uYW5zICYmIGZsYWdfdHJhcHBp bmdfbWF0aCAmJiBjb2RlICE9IEVRX0VYUFIgJiYgY29kZSAhPSBORV9FWFBS KQ0KKyAgaWYgKGhvbm9yX25hbnMgJiYgZmxhZ190cmFwcGluZ19tYXRoICYm IGNvZGUgIT0gRVFfRVhQUiAmJiBjb2RlICE9IE5FX0VYUFINCisgICAgICAm JiBjb2RlICE9IE9SREVSRURfRVhQUiAmJiBjb2RlICE9IFVOT1JERVJFRF9F WFBSKQ0KICAgICByZXR1cm4gRVJST1JfTUFSSzsNCiANCiAgIHN3aXRjaCAo Y29kZSkNCiAgICAgew0KICAgICBjYXNlIEVRX0VYUFI6DQogICAgICAgcmV0 dXJuIE5FX0VYUFI7DQogICAgIGNhc2UgTkVfRVhQUjoNCiAgICAgICByZXR1 cm4gRVFfRVhQUjsNCiAgICAgY2FzZSBHVF9FWFBSOg0KICAgICAgIHJldHVy biBob25vcl9uYW5zID8gVU5MRV9FWFBSIDogTEVfRVhQUjsNCg== --935445242-634381134-1343911688=:7013--