* [testsuite] PR 54868
@ 2012-10-11 12:35 Marc Glisse
2012-10-11 13:36 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: Marc Glisse @ 2012-10-11 12:35 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: TEXT/PLAIN, Size: 501 bytes --]
Hello,
understanding the testsuite is hard, but this patch seems to work. The
idea is that vect_double and others don't tell that vectors are supported
with these options, just that there exist options that enable vectors.
They are thus useless outside of a directory like vect/ that adds those
flags.
2012-10-11 Marc Glisse <marc.glisse@inria.fr>
PR testsuite/54868
* gcc.dg/tree-ssa/forwprop-22.c: Move ...
* gcc.dg/vect/nodump-forwprop-22.c: ... here. Adapt options.
--
Marc Glisse
[-- Attachment #2: Type: TEXT/PLAIN, Size: 694 bytes --]
Index: gcc.dg/vect/nodump-forwprop-22.c
===================================================================
--- gcc.dg/vect/nodump-forwprop-22.c (revision 192348)
+++ gcc.dg/vect/nodump-forwprop-22.c (working copy)
@@ -1,14 +1,14 @@
/* { dg-do compile } */
/* { dg-require-effective-target vect_double } */
/* { dg-require-effective-target vect_perm } */
-/* { dg-options "-O -fdump-tree-copyprop1" } */
+/* { dg-additional-options "-fdump-tree-copyprop1" } */
typedef double vec __attribute__((vector_size (2 * sizeof (double))));
void f (vec *px, vec *y, vec *z)
{
vec x = *px;
vec t1 = { x[1], x[0] };
vec t2 = { x[0], x[1] };
*y = t1;
*z = t2;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [testsuite] PR 54868
2012-10-11 12:35 [testsuite] PR 54868 Marc Glisse
@ 2012-10-11 13:36 ` Richard Biener
2012-10-11 13:42 ` Marc Glisse
0 siblings, 1 reply; 3+ messages in thread
From: Richard Biener @ 2012-10-11 13:36 UTC (permalink / raw)
To: Marc Glisse; +Cc: gcc-patches
On Thu, Oct 11, 2012 at 2:19 PM, Marc Glisse <marc.glisse@inria.fr> wrote:
> Hello,
>
> understanding the testsuite is hard, but this patch seems to work. The idea
> is that vect_double and others don't tell that vectors are supported with
> these options, just that there exist options that enable vectors. They are
> thus useless outside of a directory like vect/ that adds those flags.
Ok. But you need to cleanup vect dumps as those are enabled by default
in vect.exp I think. Just check for remaining files in gcc/testsuite/gcc
when running testing with RUNTESTFLAGS="vect.exp=nodump-forwprop-22.c".
Ah, nodump- ... (I hate those weird name-based vect tests ...), so probably
fine as is.
Thanks,
Richard.
> 2012-10-11 Marc Glisse <marc.glisse@inria.fr>
>
> PR testsuite/54868
> * gcc.dg/tree-ssa/forwprop-22.c: Move ...
> * gcc.dg/vect/nodump-forwprop-22.c: ... here. Adapt options.
>
> --
> Marc Glisse
> Index: gcc.dg/vect/nodump-forwprop-22.c
> ===================================================================
> --- gcc.dg/vect/nodump-forwprop-22.c (revision 192348)
> +++ gcc.dg/vect/nodump-forwprop-22.c (working copy)
> @@ -1,14 +1,14 @@
> /* { dg-do compile } */
> /* { dg-require-effective-target vect_double } */
> /* { dg-require-effective-target vect_perm } */
> -/* { dg-options "-O -fdump-tree-copyprop1" } */
> +/* { dg-additional-options "-fdump-tree-copyprop1" } */
>
> typedef double vec __attribute__((vector_size (2 * sizeof (double))));
> void f (vec *px, vec *y, vec *z)
> {
> vec x = *px;
> vec t1 = { x[1], x[0] };
> vec t2 = { x[0], x[1] };
> *y = t1;
> *z = t2;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [testsuite] PR 54868
2012-10-11 13:36 ` Richard Biener
@ 2012-10-11 13:42 ` Marc Glisse
0 siblings, 0 replies; 3+ messages in thread
From: Marc Glisse @ 2012-10-11 13:42 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
On Thu, 11 Oct 2012, Richard Biener wrote:
> On Thu, Oct 11, 2012 at 2:19 PM, Marc Glisse <marc.glisse@inria.fr> wrote:
>> Hello,
>>
>> understanding the testsuite is hard, but this patch seems to work. The idea
>> is that vect_double and others don't tell that vectors are supported with
>> these options, just that there exist options that enable vectors. They are
>> thus useless outside of a directory like vect/ that adds those flags.
>
> Ok. But you need to cleanup vect dumps as those are enabled by default
> in vect.exp I think. Just check for remaining files in gcc/testsuite/gcc
> when running testing with RUNTESTFLAGS="vect.exp=nodump-forwprop-22.c".
> Ah, nodump- ... (I hate those weird name-based vect tests ...), so probably
> fine as is.
I didn't notice any remaining file, so I committed as is. Having the
testcase compiled with -ftree-vectorize isn't great, but it doesn't hurt
:-/
--
Marc Glisse
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-11 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-11 12:35 [testsuite] PR 54868 Marc Glisse
2012-10-11 13:36 ` Richard Biener
2012-10-11 13:42 ` Marc Glisse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).