From: Marc Glisse <marc.glisse@inria.fr>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: ebotcazou@adacore.com, gcc-patches@gcc.gnu.org,
Uros Bizjak <ubizjak@gmail.com>,
"H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [i386] scalar ops that preserve the high part of a vector
Date: Wed, 05 Dec 2012 20:22:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1212051825230.29437@stedding.saclay.inria.fr> (raw)
In-Reply-To: <50BF7F36.7010101@gnu.org>
On Wed, 5 Dec 2012, Paolo Bonzini wrote:
> Il 05/12/2012 15:22, Marc Glisse ha scritto:
>> +
>> + /* The x86 back-end uses VEC_CONCAT to set an element in a V2DF, but
>> + VEC_MERGE for scalar operations that preserve the other elements
>> + of a vector. */
>> + if (GET_CODE (trueop1) == VEC_SELECT
>> + && GET_MODE (XEXP (trueop1, 0)) == mode
>> + && XVECLEN (XEXP (trueop1, 1), 0) == 1
>> + && INTVAL (XVECEXP (XEXP (trueop1, 1), 0, 0)) == 1)
>> + {
>> + rtx newop0 = gen_rtx_fmt_e (VEC_DUPLICATE, mode, trueop0);
>> + rtx newop1 = XEXP (trueop1, 0);
>> + return gen_rtx_fmt_eee (VEC_MERGE, mode, newop0, newop1,
>> + const1_rtx);
>> + }
>
> So this changes this:
>
> (vec_concat:M R1:N (vec_select:N V2:M [1]))
>
> to this
>
> (vec_merge:M (vec_duplicate:M R1:N) V2:M [1])
Yes.
> I wonder if more patterns in i386.md should be canonicalized.
> Basically, the occurrences of gen_rtx_VEC_CONCAT should be changed to
> simplify_gen_binary, and the fallout fixed.
>
> Otherwise you have patterns that will not match if someone does generate
> the vec_concat via simplify_gen_binary.
I wondered about that but underestimated the issue. If we decide that the
vec_merge pattern is the canonical one, we should probably start by making
ix86_expand_vector_set and others generate it (instead of the vec_concat
one), and the simplify-rtx patch actually becomes less useful (but not
useless).
I don't know Uros' position, but re-reading this message:
http://gcc.gnu.org/ml/gcc-patches/2012-12/msg00069.html
it seems like he was indeed suggesting this.
Note that my first choice was to have the vec_concat pattern in sse.md (I
like the vec_concat pattern better, and since ix86_expand_vector_set has a
special case to generate it instead of vec_merge for V2DF, someone must
have agreed at some point), but Uros wants a single entry (using macros)
for V4SF+V2DF, and hence a similar pattern.
The only simplification we currently have with VEC_MERGE is constant
propagation. If we are going to produce it more often, we need to add a
few optimizations, like looking through a vec_select of a vec_merge, or
doing nothing when merging a vector with itself, etc.
--
Marc Glisse
next prev parent reply other threads:[~2012-12-05 20:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 9:33 Marc Glisse
2012-10-14 9:54 ` Uros Bizjak
2012-10-14 12:52 ` Marc Glisse
2012-11-30 12:36 ` Marc Glisse
2012-11-30 13:55 ` Uros Bizjak
2012-11-30 22:36 ` Marc Glisse
2012-12-01 17:27 ` Marc Glisse
2012-12-02 10:51 ` Uros Bizjak
2012-12-02 12:30 ` Marc Glisse
2012-12-03 8:53 ` Uros Bizjak
2012-12-03 15:34 ` Marc Glisse
2012-12-03 17:55 ` Uros Bizjak
2012-12-04 14:05 ` Marc Glisse
2012-12-04 16:28 ` Marc Glisse
2012-12-04 18:06 ` Uros Bizjak
2012-12-04 18:12 ` H.J. Lu
2012-12-06 13:42 ` Kirill Yukhin
2012-12-07 6:50 ` Michael Zolotukhin
2012-12-07 8:46 ` Uros Bizjak
2012-12-07 8:49 ` Marc Glisse
2012-12-07 10:52 ` Michael Zolotukhin
2012-12-07 14:02 ` Marc Glisse
2012-12-07 14:43 ` Richard Henderson
2012-12-07 14:47 ` Jakub Jelinek
2012-12-07 14:53 ` Richard Henderson
2012-12-07 15:00 ` Marc Glisse
2012-12-07 15:06 ` Richard Henderson
2012-12-07 15:12 ` Marc Glisse
2012-12-07 16:24 ` Richard Henderson
2012-12-07 17:23 ` Marc Glisse
2012-12-08 5:47 ` Marc Glisse
2012-12-12 15:48 ` Richard Henderson
2012-12-05 14:22 ` Marc Glisse
2012-12-05 17:07 ` Paolo Bonzini
2012-12-05 20:22 ` Marc Glisse [this message]
2012-12-05 21:05 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1212051825230.29437@stedding.saclay.inria.fr \
--to=marc.glisse@inria.fr \
--cc=bonzini@gnu.org \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).