From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49325 invoked by alias); 14 May 2015 14:04:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 49314 invoked by uid 89); 14 May 2015 14:04:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_ASCII_DIVIDERS,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mail2-relais-roc.national.inria.fr Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 14 May 2015 14:04:31 +0000 Received: from stedding.saclay.inria.fr (HELO stedding) ([193.55.250.194]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-SHA; 14 May 2015 16:04:28 +0200 Received: from glisse (helo=localhost) by stedding with local-esmtp (Exim 4.85) (envelope-from ) id 1YstkR-0000Vz-Nx; Thu, 14 May 2015 16:04:27 +0200 Date: Thu, 14 May 2015 14:21:00 -0000 From: Marc Glisse To: Jeff Law cc: gcc-patches@gcc.gnu.org Subject: Re: [RFA] More type narrowing in match.pd V2 In-Reply-To: <55441BF2.60703@redhat.com> Message-ID: References: <55441BF2.60703@redhat.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-460634193-1431612267=:30908" X-SW-Source: 2015-05/txt/msg01327.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-460634193-1431612267=:30908 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Content-length: 701 On Fri, 1 May 2015, Jeff Law wrote: > Slight refactoring of the condition by using types_match as suggested by > Richi. I also applied the new types_match to 2 other patterns in match.pd > where it seemed clearly appropriate. I would like to propose this small tweak (regtested ok). If we had a different type for trees and types, this would be overloading the function. We already do this in a few places, and I find the resulting shorter code more readable. 2015-05-14 Marc Glisse * generic-match-head.c (types_match): Handle non-types. * gimple-match-head.c (types_match): Likewise. * match.pd: Remove unnecessary TREE_TYPE for types_match. -- Marc Glisse --8323329-460634193-1431612267=:30908 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=p5 Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: inline; filename=p5 Content-length: 3608 SW5kZXg6IGdjYy9nZW5lcmljLW1hdGNoLWhlYWQuYw0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQ0KLS0tIGdjYy9nZW5lcmljLW1hdGNoLWhlYWQuYwkocmV2 aXNpb24gMjIzMTk0KQ0KKysrIGdjYy9nZW5lcmljLW1hdGNoLWhlYWQuYwko d29ya2luZyBjb3B5KQ0KQEAgLTc2LDYgKzc2LDExIEBADQogc3RhdGljIGlu bGluZSBib29sDQogdHlwZXNfbWF0Y2ggKHRyZWUgdDEsIHRyZWUgdDIpDQog ew0KKyAgaWYgKCFUWVBFX1AgKHQxKSkNCisgICAgdDEgPSBUUkVFX1RZUEUg KHQxKTsNCisgIGlmICghVFlQRV9QICh0MikpDQorICAgIHQyID0gVFJFRV9U WVBFICh0Mik7DQorDQogICByZXR1cm4gVFlQRV9NQUlOX1ZBUklBTlQgKHQx KSA9PSBUWVBFX01BSU5fVkFSSUFOVCAodDIpOw0KIH0NCiANCkluZGV4OiBn Y2MvZ2ltcGxlLW1hdGNoLWhlYWQuYw0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQ0KLS0tIGdjYy9naW1wbGUtbWF0Y2gtaGVhZC5jCShyZXZpc2lvbiAyMjMx OTQpDQorKysgZ2NjL2dpbXBsZS1tYXRjaC1oZWFkLmMJKHdvcmtpbmcgY29w eSkNCkBAIC04NjcsNiArODY3LDExIEBADQogc3RhdGljIGlubGluZSBib29s DQogdHlwZXNfbWF0Y2ggKHRyZWUgdDEsIHRyZWUgdDIpDQogew0KKyAgaWYg KCFUWVBFX1AgKHQxKSkNCisgICAgdDEgPSBUUkVFX1RZUEUgKHQxKTsNCisg IGlmICghVFlQRV9QICh0MikpDQorICAgIHQyID0gVFJFRV9UWVBFICh0Mik7 DQorDQogICByZXR1cm4gdHlwZXNfY29tcGF0aWJsZV9wICh0MSwgdDIpOw0K IH0NCiANCkluZGV4OiBnY2MvbWF0Y2gucGQNCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0NCi0tLSBnY2MvbWF0Y2gucGQJKHJldmlzaW9uIDIyMzE5NCkNCisr KyBnY2MvbWF0Y2gucGQJKHdvcmtpbmcgY29weSkNCkBAIC0yODksNyArMjg5 LDcgQEANCiAgIChpZiAoKChUUkVFX0NPREUgKEAxKSA9PSBJTlRFR0VSX0NT VA0KIAkgJiYgSU5URUdSQUxfVFlQRV9QIChUUkVFX1RZUEUgKEAwKSkNCiAJ ICYmIGludF9maXRzX3R5cGVfcCAoQDEsIFRSRUVfVFlQRSAoQDApKSkNCi0J fHwgdHlwZXNfbWF0Y2ggKFRSRUVfVFlQRSAoQDApLCBUUkVFX1RZUEUgKEAx KSkpDQorCXx8IHR5cGVzX21hdGNoIChAMCwgQDEpKQ0KICAgICAgICAvKiA/ Pz8gIFRoaXMgdHJhbnNmb3JtIGNvbmZsaWN0cyB3aXRoIGZvbGQtY29uc3Qu YyBkb2luZw0KIAkgIENvbnZlcnQgKFQpKHggJiBjKSBpbnRvIChUKXggJiAo VCljLCBpZiBjIGlzIGFuIGludGVnZXINCiAJICBjb25zdGFudHMgKGlmIHgg aGFzIHNpZ25lZCB0eXBlLCB0aGUgc2lnbiBiaXQgY2Fubm90IGJlIHNldA0K QEAgLTk0OCw3ICs5NDgsNyBAQA0KIC8qIFVub3JkZXJlZCB0ZXN0cyBpZiBl aXRoZXIgYXJndW1lbnQgaXMgYSBOYU4uICAqLw0KIChzaW1wbGlmeQ0KICAo Yml0X2lvciAodW5vcmRlcmVkIEAwIEAwKSAodW5vcmRlcmVkIEAxIEAxKSkN Ci0gKGlmICh0eXBlc19tYXRjaCAoVFJFRV9UWVBFIChAMCksIFRSRUVfVFlQ RSAoQDEpKSkNCisgKGlmICh0eXBlc19tYXRjaCAoQDAsIEAxKSkNCiAgICh1 bm9yZGVyZWQgQDAgQDEpKSkNCiAoc2ltcGxpZnkNCiAgKGJpdF9pb3I6YyAo dW5vcmRlcmVkIEAwIEAwKSAodW5vcmRlcmVkOmNAMiBAMCBAMSkpDQpAQCAt MTA2OCw4ICsxMDY4LDggQEANCiAJICYmIFRZUEVfUFJFQ0lTSU9OICh0eXBl KSA9PSBHRVRfTU9ERV9QUkVDSVNJT04gKFRZUEVfTU9ERSAodHlwZSkpDQog CSAvKiBUaGUgaW5uZXIgY29udmVyc2lvbiBtdXN0IGJlIGEgd2lkZW5pbmcg Y29udmVyc2lvbi4gICovDQogCSAmJiBUWVBFX1BSRUNJU0lPTiAoVFJFRV9U WVBFIChAMikpID4gVFlQRV9QUkVDSVNJT04gKFRSRUVfVFlQRSAoQDApKQ0K LQkgJiYgdHlwZXNfbWF0Y2ggKFRSRUVfVFlQRSAoQDApLCBUUkVFX1RZUEUg KEAxKSkNCi0JICYmIHR5cGVzX21hdGNoIChUUkVFX1RZUEUgKEAwKSwgdHlw ZSkNCisJICYmIHR5cGVzX21hdGNoIChAMCwgQDEpDQorCSAmJiB0eXBlc19t YXRjaCAoQDAsIHR5cGUpDQogCSAmJiBzaW5nbGVfdXNlIChANCkpDQogICAg ICAgKGlmIChUWVBFX09WRVJGTE9XX1dSQVBTIChUUkVFX1RZUEUgKEAwKSkp DQogCShjb252ZXJ0IChvcCBAMCBAMSkpKQ0KQEAgLTEwOTksNyArMTA5OSw3 IEBADQogCSAmJiBUWVBFX1BSRUNJU0lPTiAodHlwZSkgPT0gR0VUX01PREVf UFJFQ0lTSU9OIChUWVBFX01PREUgKHR5cGUpKQ0KIAkgLyogVGhlIGlubmVy IGNvbnZlcnNpb24gbXVzdCBiZSBhIHdpZGVuaW5nIGNvbnZlcnNpb24uICAq Lw0KIAkgJiYgVFlQRV9QUkVDSVNJT04gKFRSRUVfVFlQRSAoQDIpKSA+IFRZ UEVfUFJFQ0lTSU9OIChUUkVFX1RZUEUgKEAwKSkNCi0JICYmIHR5cGVzX21h dGNoIChUUkVFX1RZUEUgKEAwKSwgVFJFRV9UWVBFIChAMSkpDQorCSAmJiB0 eXBlc19tYXRjaCAoQDAsIEAxKQ0KIAkgJiYgKHRyZWVfaW50X2NzdF9taW5f cHJlY2lzaW9uIChANCwgVU5TSUdORUQpDQogCSAgICAgPD0gVFlQRV9QUkVD SVNJT04gKFRSRUVfVFlQRSAoQDApKSkNCiAJICYmIHNpbmdsZV91c2UgKEA1 KSkNCg== --8323329-460634193-1431612267=:30908--