From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48036 invoked by alias); 28 Jun 2015 11:45:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 48023 invoked by uid 89); 28 Jun 2015 11:45:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mail2-relais-roc.national.inria.fr Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Sun, 28 Jun 2015 11:45:15 +0000 Received: from ip-0.net-81-220-131.standre.rev.numericable.fr (HELO laptop-mg.local) ([81.220.131.0]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 28 Jun 2015 13:45:12 +0200 Date: Sun, 28 Jun 2015 14:09:00 -0000 From: Marc Glisse To: Richard Biener cc: GCC Patches , richard.sandiford@arm.com Subject: Re: Remove redundant AND from count reduction loop In-Reply-To: Message-ID: References: <87pp4m8mkp.fsf@e105548-lin.cambridge.arm.com> <87egl1sa2p.fsf@e105548-lin.cambridge.arm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-199014573-1435491912=:22260" X-SW-Source: 2015-06/txt/msg02027.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-199014573-1435491912=:22260 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Content-length: 1320 On Fri, 26 Jun 2015, Richard Biener wrote: >>>> OK. The reason I was being paranoid was that I couldn't see anywhere >>>> where we enforced that the vector condition in a VEC_COND had to have >>>> the same element width as the values being selected. >>> >>> >>> We don't require that indeed. >>> >>>> tree-cfg.c >>>> only checks that rhs2 and rhs3 are compatible with the result. >>>> There doesn't seem to be any checking of rhs1 vs. the other types. >>>> So I wasn't sure whether anything stopped us from, e.g., comparing two >>>> V4HIs and using the result to select between two V4SIs. >>> >>> >>> Nothing does (or should). >> >> >> The documentation patch you approved in >> https://gcc.gnu.org/ml/gcc-patches/2012-10/msg01109.html says something >> different. If it is really wrong, could you fix it? > > Hmm, that simplifies things. On the other hand, vectors of bools could be (I haven't thought about it much) nice to have, especially for avx512 (and at least one other arch, maybe sparc). > It would be nice if these constraints would also be checked in the > gimple verifier... This passed bootstrap+testsuite on powerpc64le-unknown-linux-gnu. 2015-06-29 Marc Glisse * tree-cfg.c (verify_gimple_assign_ternary) : Check the first argument. -- Marc Glisse --8323329-199014573-1435491912=:22260 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=p0 Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: inline; filename=p0 Content-length: 1261 SW5kZXg6IGdjYy90cmVlLWNmZy5jDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 DQotLS0gZ2NjL3RyZWUtY2ZnLmMJKHJldmlzaW9uIDIyNTEwNCkNCisrKyBn Y2MvdHJlZS1jZmcuYwkod29ya2luZyBjb3B5KQ0KQEAgLTQwMDEsOCArNDAw MSwyMiBAQA0KIAl9DQogICAgICAgYnJlYWs7DQogDQorICAgIGNhc2UgVkVD X0NPTkRfRVhQUjoNCisgICAgICBpZiAoIVZFQ1RPUl9JTlRFR0VSX1RZUEVf UCAocmhzMV90eXBlKQ0KKwkgIHx8IFRZUEVfU0lHTiAocmhzMV90eXBlKSAh PSBTSUdORUQNCisJICB8fCBUWVBFX1NJWkUgKHJoczFfdHlwZSkgIT0gVFlQ RV9TSVpFIChsaHNfdHlwZSkNCisJICB8fCBUWVBFX1ZFQ1RPUl9TVUJQQVJU UyAocmhzMV90eXBlKQ0KKwkgICAgICE9IFRZUEVfVkVDVE9SX1NVQlBBUlRT IChsaHNfdHlwZSkpDQorCXsNCisJICBlcnJvciAoInRoZSBmaXJzdCBhcmd1 bWVudCBvZiBhIFZFQ19DT05EX0VYUFIgbXVzdCBiZSBvZiBhIHNpZ25lZCAi DQorCQkgImludGVncmFsIHZlY3RvciB0eXBlIG9mIHRoZSBzYW1lIHNpemUg YW5kIG51bWJlciBvZiAiDQorCQkgImVsZW1lbnRzIGFzIHRoZSByZXN1bHQi KTsNCisJICBkZWJ1Z19nZW5lcmljX2V4cHIgKGxoc190eXBlKTsNCisJICBk ZWJ1Z19nZW5lcmljX2V4cHIgKHJoczFfdHlwZSk7DQorCSAgcmV0dXJuIHRy dWU7DQorCX0NCisgICAgICAvKiBGYWxsdGhyb3VnaC4gICovDQogICAgIGNh c2UgQ09ORF9FWFBSOg0KLSAgICBjYXNlIFZFQ19DT05EX0VYUFI6DQogICAg ICAgaWYgKCF1c2VsZXNzX3R5cGVfY29udmVyc2lvbl9wIChsaHNfdHlwZSwg cmhzMl90eXBlKQ0KIAkgIHx8ICF1c2VsZXNzX3R5cGVfY29udmVyc2lvbl9w IChsaHNfdHlwZSwgcmhzM190eXBlKSkNCiAJew0K --8323329-199014573-1435491912=:22260--