public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Marc Glisse <marc.glisse@inria.fr>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [C++] Fix __builtin_shuffle
Date: Fri, 28 Jun 2013 10:34:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.10.1306281232000.3911@laptop-mg.saclay.inria.fr> (raw)
In-Reply-To: <alpine.DEB.2.10.1306280909340.3911@laptop-mg.saclay.inria.fr>

On Fri, 28 Jun 2013, Marc Glisse wrote:

> It seems better to do the following, so we still test for extra warnings:
>
> -template <class T> void g (T) {}
> -template <class T> auto g (T x) -> typename 
> enable_if<sizeof(__builtin_shuffle(x,x))!=2>::type {}
> +template <class T> void g (T const&) {}
> +template <class T> auto g (T const& x) -> typename 
> enable_if<sizeof(__builtin_shuffle(x,x))!=2>::type {}

I committed that as an obvious fix of my testcase.

2013-06-28  Marc Glisse  <marc.glisse@inria.fr>

 	PR c++/57509
 	* g++.dg/ext/pr57509.C: Pass vectors by reference to avoid warnings.


-- 
Marc Glisse

      reply	other threads:[~2013-06-28 10:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-09 11:09 Marc Glisse
2013-06-26 14:20 ` Marc Glisse
2013-06-26 20:56 ` Jason Merrill
2013-06-27 11:59   ` Marc Glisse
2013-06-27 12:27     ` Jason Merrill
2013-06-27 15:29       ` Marc Glisse
2013-06-27 15:40         ` Jakub Jelinek
2013-06-27 15:55           ` Marc Glisse
2013-06-27 16:09             ` Jakub Jelinek
2013-06-27 16:10               ` Marc Glisse
2013-06-27 21:58                 ` Marc Glisse
2013-06-28  6:20     ` Jakub Jelinek
2013-06-28  8:48       ` Marc Glisse
2013-06-28 10:34         ` Marc Glisse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1306281232000.3911@laptop-mg.saclay.inria.fr \
    --to=marc.glisse@inria.fr \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).