From: Joseph Myers <joseph@codesourcery.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: Torvald Riegel <triegel@redhat.com>,
Richard Biener <richard.guenther@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>
Subject: Re: [PATCH] PR59448 - Promote consume to acquire
Date: Wed, 14 Jan 2015 19:00:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.10.1501141828290.20530@digraph.polyomino.org.uk> (raw)
In-Reply-To: <54B68ECD.5070409@redhat.com>
On Wed, 14 Jan 2015, Andrew MacLeod wrote:
> - There is a warning for invalid memory models already, so I just continued
> using that.
> - I remove the check for CONSUME in exchange since the current standard makes
> no mention of that being illegal.
> - I also reversed the current check in compare_exchange to check for failure >
> success first, allowing us to still catch both errors if present.
>
> I think this brings us to where we ought to be... at least almost :-)
> The latest version I have is n3337, which still specifies that atomic_clear
> can't be memory_order_acquire or memory_order_acq_rel. Has that been updated
> to specify that memory_order_consume is not allowed either? I think there was
> a request in at some point... I can add that if so.
>
> Bootstraps on x86_64-unknown-linux-gnu, and no regressions in the testsuite.
>
> OK for trunk?
OK.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2015-01-14 18:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 14:59 Andrew MacLeod
2015-01-13 15:11 ` Richard Biener
2015-01-13 15:19 ` Andrew MacLeod
2015-01-13 18:57 ` Torvald Riegel
2015-01-13 19:05 ` Jeff Law
2015-01-13 19:18 ` Andrew MacLeod
2015-01-13 22:42 ` Joseph Myers
2015-01-14 16:04 ` Andrew MacLeod
2015-01-14 16:06 ` Torvald Riegel
2015-01-14 19:00 ` Joseph Myers [this message]
2015-01-14 21:35 ` Andrew MacLeod
2015-01-13 23:47 ` Andrew MacLeod
2015-01-14 7:21 ` Jeff Law
2015-01-13 15:20 ` Torvald Riegel
2015-01-13 15:51 ` Andrew MacLeod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1501141828290.20530@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=richard.guenther@gmail.com \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).