From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100615 invoked by alias); 30 Apr 2015 17:42:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 100543 invoked by uid 89); 30 Apr 2015 17:42:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Apr 2015 17:42:07 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1YnsTI-00040b-Rd from joseph_myers@mentor.com ; Thu, 30 Apr 2015 10:42:01 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Thu, 30 Apr 2015 18:41:59 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.82) (envelope-from ) id 1YnsTF-0001k0-TS; Thu, 30 Apr 2015 17:41:58 +0000 Date: Thu, 30 Apr 2015 17:50:00 -0000 From: Joseph Myers To: Jakub Jelinek CC: Trevor Saunders , Andreas Schwab , Jeff Law , , Subject: Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS In-Reply-To: <20150430123344.GQ1751@tucnak.redhat.com> Message-ID: References: <1430114140-15817-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <1430114140-15817-4-git-send-email-tbsaunde+gcc@tbsaunde.org> <87oam7nmck.fsf@igel.home> <20150429212811.GA17482@tsaunders-iceball.corp.tor1.mozilla.com> <87383iob0i.fsf@igel.home> <5541548F.40608@redhat.com> <20150429222548.GB17482@tsaunders-iceball.corp.tor1.mozilla.com> <87r3r2i0el.fsf@igel.home> <20150430122513.GB1508@tsaunders-iceball.corp.tor1.mozilla.com> <20150430123344.GQ1751@tucnak.redhat.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2015-04/txt/msg02073.txt.bz2 On Thu, 30 Apr 2015, Jakub Jelinek wrote: > > I guess the "best" thing to do is justadd a > > __PCC_BITFIELD_TYPE_MATTERS__ that gcc defines and use that in libobjc? > > I think adding way too many predefines, especially rarely used ones, is > harmful, certainly it isn't free, consider -g3 or -dD where it will all end > up in, additional gcc start overhead, ... That's why we have -fbuilding-libgcc. It would seem reasonable enough to me to use that when building other target libraries that need such information. (See bug 24775 regarding the general issue with libobjc using GCC's struct layout target macros - I think there was an idea of a way to rework that libobjc code, but haven't looked at the details of Andrew Pinski's old work referred to in that bug; -fbuilding-libgcc may not be the optimal way of dealing with PCC_BITFIELD_TYPE_MATTERS, but ought to work as an interim fix. More generally, regarding host-side target macros used in target code, see my suggestions at . It's always necessary, when changing the semantics of a target macro or converting it into a hook, to watch out for uses outside the gcc/ directory, until all the remaining uses in target code have been dealt with.) -- Joseph S. Myers joseph@codesourcery.com