From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127024 invoked by alias); 12 Aug 2015 21:26:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 127014 invoked by uid 89); 12 Aug 2015 21:26:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Aug 2015 21:26:22 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZPdXP-0000ks-7E from joseph_myers@mentor.com ; Wed, 12 Aug 2015 14:26:19 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Wed, 12 Aug 2015 22:26:17 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.82) (envelope-from ) id 1ZPdXM-00064Y-8Z; Wed, 12 Aug 2015 21:26:16 +0000 Date: Wed, 12 Aug 2015 21:26:00 -0000 From: Joseph Myers To: Matthew Wahab CC: gcc-patches Subject: Re: [Aarch64][target/PR 67143] Use correct constraints on operands for atomic operations. In-Reply-To: <55C9F321.2080807@foss.arm.com> Message-ID: References: <55C9F321.2080807@foss.arm.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2015-08/txt/msg00662.txt.bz2 On Tue, 11 Aug 2015, Matthew Wahab wrote: > PR target/67143 > * gcc.target/aarch64/pr67143.c: New What's architecture-specific about this test? That is, why doesn't it just go in gcc.c-torture/compile (no dg- directives needed, automatically looped over optimization options)? Architecture-specific test directories should only be for tests that are actually architecture-specific (e.g. using architecture-specific options, or asm, or built-in functions, or scan-assembler for particular output), not for tests that can be built generically for all architectures and still test for the original bug. -- Joseph S. Myers joseph@codesourcery.com