From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61462 invoked by alias); 22 Oct 2015 20:37:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60872 invoked by uid 89); 22 Oct 2015 20:37:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Oct 2015 20:37:05 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZpMbd-0007Ff-MM from joseph_myers@mentor.com ; Thu, 22 Oct 2015 13:37:01 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Thu, 22 Oct 2015 21:36:40 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.82) (envelope-from ) id 1ZpMbH-0007T6-Ap; Thu, 22 Oct 2015 20:36:39 +0000 Date: Thu, 22 Oct 2015 20:42:00 -0000 From: Joseph Myers To: James Norris CC: GCC Patches , Nathan Sidwell , Jakub Jelinek Subject: Re: [OpenACC 0/7] host_data construct In-Reply-To: <56293476.5020801@codesourcery.com> Message-ID: References: <56293476.5020801@codesourcery.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2015-10/txt/msg02352.txt.bz2 I think this patch is small enough, and the pieces insufficiently self-contained, that splitting it up rather than posting as one patch just makes it harder to understand. My strong preference is that the same patch that introduces a feature should also add the testcases for that feature, for example - they should not be split out (that's not even a split by reviewer, testcases are critical to reviewing functionality patches). -- Joseph S. Myers joseph@codesourcery.com