From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18916 invoked by alias); 10 Nov 2015 01:32:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18905 invoked by uid 89); 10 Nov 2015 01:32:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Nov 2015 01:32:46 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Zvxne-0002my-DB from joseph_myers@mentor.com ; Mon, 09 Nov 2015 17:32:42 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 10 Nov 2015 01:32:40 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.82) (envelope-from ) id 1Zvxnb-0000eD-K4; Tue, 10 Nov 2015 01:32:39 +0000 Date: Tue, 10 Nov 2015 01:32:00 -0000 From: Joseph Myers To: Trevor Saunders CC: Jeff Law , Bernd Schmidt , , Subject: Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX In-Reply-To: <20151109213003.GH22527@tsaunders-iceball.corp.tor1.mozilla.com> Message-ID: References: <1447087669-14039-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <1447087669-14039-11-git-send-email-tbsaunde+gcc@tbsaunde.org> <5640E580.90607@redhat.com> <5640E90B.8060808@redhat.com> <20151109185201.GC22527@tsaunders-iceball.corp.tor1.mozilla.com> <5640F645.1000002@redhat.com> <5640F819.7070102@redhat.com> <20151109213003.GH22527@tsaunders-iceball.corp.tor1.mozilla.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2015-11/txt/msg01148.txt.bz2 On Mon, 9 Nov 2015, Trevor Saunders wrote: > The add default macro definitions then wrap those with hooks, then > target by target replace the macro by hook overrides approach seems to > provide that you can incrementally test and fiind most of the issues, > but the change a macro every where approach doesn't really. I have this notion that once a target macro is "regular" enough - not used in code built for the target, not used in driver code, not used directly or indirectly in #if conditions except for the single default definition in defaults.h, target definitions only depend on the target architecture and not OS or other variations - it ought to be possible to do the conversion to a hook with some kind of automated refactoring tool (possibly with a little editing of its results). And so this sort of regularizing of target macros is helpful because it increases the number of target macros that could be converted in an automated manner. -- Joseph S. Myers joseph@codesourcery.com