From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90318 invoked by alias); 10 Nov 2015 17:55:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 90307 invoked by uid 89); 10 Nov 2015 17:55:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Nov 2015 17:55:30 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZwD8g-0000xT-Do from joseph_myers@mentor.com ; Tue, 10 Nov 2015 09:55:26 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 10 Nov 2015 17:55:20 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.82) (envelope-from ) id 1ZwD8Y-0005Oh-Ng; Tue, 10 Nov 2015 17:55:18 +0000 Date: Tue, 10 Nov 2015 17:55:00 -0000 From: Joseph Myers To: David Malcolm CC: Subject: Re: [PATCH 02/02] C FE: add fix-it hint for . vs -> In-Reply-To: <1447173325-48683-2-git-send-email-dmalcolm@redhat.com> Message-ID: References: <1447173325-48683-1-git-send-email-dmalcolm@redhat.com> <1447173325-48683-2-git-send-email-dmalcolm@redhat.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2015-11/txt/msg01260.txt.bz2 On Tue, 10 Nov 2015, David Malcolm wrote: > This is the most trivial example of a real fix-it example I could think > of: if the user writes > ptr.field > rather than ptr->field. > > gcc/c/ChangeLog: > * c-typeck.c (build_component_ref): Special-case POINTER_TYPE when > generating a "not a structure of union" error message, and > suggest a "->" rather than a ".", providing a fix-it hint. I wonder if this should be restricted to the case where the pointer's target is of structure or union type. At least, if it's some other type, more of a fix is needed than just using -> (e.g. converting from void * to a pointer to the relevant type). -- Joseph S. Myers joseph@codesourcery.com