From: Joseph Myers <joseph@codesourcery.com>
To: Hongxu Jia <hongxu.jia@windriver.com>
Cc: <jakub@gcc.gnu.org>, <rguenth@gcc.gnu.org>,
<gcc-patches@gcc.gnu.org>, <richard.purdie@linuxfoundation.org>
Subject: Re: [PATCH]PR other/70268: map one directory name (old) to another (new) in __FILE__
Date: Thu, 17 Mar 2016 22:47:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.10.1603172242460.18027@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1458205064-10251-1-git-send-email-hongxu.jia@windriver.com>
On Thu, 17 Mar 2016, Hongxu Jia wrote:
> + if (add_file_prefix_map(arg) < 0)
Bad formatting (missing space before '('). Likewise elsewhere in this
patch.
> +@item -ffile-prefix-map=@var{old}=@var{new}
> +@opindex ffile-prefix-map
> +When parsing __FILE__, __BASE_FILE__ and __builtin_FILE(), use directory
> +@file{@var{new}} to replace @file{@var{old}}.
Missing use of @code{} around literal source code text.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-03-17 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 8:57 Hongxu Jia
2016-03-17 9:54 ` [PATCH V2]PR " Hongxu Jia
2016-03-17 22:47 ` Joseph Myers [this message]
2016-03-18 2:30 ` [PATCH]PR " Hongxu Jia
2016-03-18 7:56 ` [PATCH V3]PR " Hongxu Jia
2016-03-18 8:05 ` Bernhard Reutner-Fischer
2016-03-18 8:11 ` Hongxu Jia
2016-03-18 9:36 ` Hongxu Jia
2016-03-23 7:49 ` Hongxu Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1603172242460.18027@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongxu.jia@windriver.com \
--cc=jakub@gcc.gnu.org \
--cc=rguenth@gcc.gnu.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).