Re: Warn when returning the address of a temporary (middle-end) v2

[Marc Glisse <marc.glisse@inria.fr>]

On Sun, 27 Jul 2014, Andreas Schwab wrote:

> Marc Glisse <marc.glisse@inria.fr> writes:
>
>> On Sun, 27 Jul 2014, Richard Sandiford wrote:
>>
>>> Marc Glisse <marc.glisse@inria.fr> writes:
>>>> +		      if (always_executed)
>>>> +			msg = "function returns address of local variable";
>>>> +		      else
>>>> +			msg = "function may return address of local variable";
>>>
>>> I think you need _(...) here, unless some magic makes that unnecessary now.
>>
>> I just tried to see how the magic happens when someone calls error_at, and
>> it goes through diagnostic_set_info, which contains:
>>
>> diagnostic_set_info_translated (diagnostic, _(gmsgid), args, location, kind);
>>
>> So I think the _(...) is already taken care of. But I don't know that code
>> at all and I could easily have looked at it wrong.
>
> If the msgid is not a direct argument of the diagnostic function you
> need to mark the string with N_(...).

Ah, ok, thanks.
Actually, shouldn't it be G_ instead? That's what ABOUT-GCC-NLS seems to 
suggest since 2005, though I don't expect it makes any difference for 
simple strings.

-- 
Marc Glisse