From: Marc Glisse <marc.glisse@inria.fr>
To: Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
Cc: gcc-patches@gcc.gnu.org, rguenther@suse.de, law@redhat.com
Subject: Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
Date: Sat, 14 Nov 2015 08:13:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1511140907420.1923@laptop-mg.saclay.inria.fr> (raw)
In-Reply-To: <20151114071148.GA16647@jaguar.atmel.com>
On Sat, 14 Nov 2015, Senthil Kumar Selvaraj wrote:
> This patch came out of a discussion held in the gcc mailing list
> (https://gcc.gnu.org/ml/gcc/2015-11/msg00067.html).
>
> The patch restricts folding of conditional exprs with lhs previously
> set by a type conversion to occur only if the source of the type
> conversion's mode is word mode or smaller.
>
> Bootstrapped and reg tested on x86_64 (with --enable-languages=c,c++).
>
> If ok, could you commit please? I don't have commit access.
>
> Regards
> Senthil
>
> gcc/ChangeLog
>
> 2015-11-11 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
>
> * tree-vrp.c (simplify_cond_using_ranges): Fold only
> if innerop's mode is word_mode or smaller.
>
>
> diff --git gcc/tree-vrp.c gcc/tree-vrp.c
> index e2393e4..c139bc6 100644
> --- gcc/tree-vrp.c
> +++ gcc/tree-vrp.c
> @@ -9467,6 +9467,8 @@ simplify_cond_using_ranges (gcond *stmt)
> innerop = gimple_assign_rhs1 (def_stmt);
>
> if (TREE_CODE (innerop) == SSA_NAME
> + && (GET_MODE_SIZE(TYPE_MODE(TREE_TYPE(innerop)))
> + <= GET_MODE_SIZE(word_mode))
> && !POINTER_TYPE_P (TREE_TYPE (innerop)))
> {
> value_range *vr = get_value_range (innerop);
I thought the result of the discussion was that the transformation is ok
if either it is narrowing or it widens but to something no bigger than
word_mode. So you should have 2 comparisons, or 1 with a max.
--
Marc Glisse
next prev parent reply other threads:[~2015-11-14 8:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 7:12 Senthil Kumar Selvaraj
2015-11-14 8:13 ` Marc Glisse [this message]
2015-11-14 8:50 ` Senthil Kumar Selvaraj
2015-11-14 8:57 ` Richard Biener
2015-11-14 18:11 ` Senthil Kumar Selvaraj
2015-11-16 9:02 ` Richard Biener
2015-11-17 19:53 ` Senthil Kumar Selvaraj
2015-11-18 8:36 ` Richard Biener
2015-11-19 6:20 ` Senthil Kumar Selvaraj
2015-11-19 17:31 ` Jeff Law
2015-11-20 17:04 ` Senthil Kumar Selvaraj
2015-11-20 17:34 ` Jeff Law
2015-11-23 9:54 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1511140907420.1923@laptop-mg.saclay.inria.fr \
--to=marc.glisse@inria.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=rguenther@suse.de \
--cc=senthil_kumar.selvaraj@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).