From: Joseph Myers <joseph@codesourcery.com>
To: Matthew Wahab <matthew.wahab@foss.arm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 16/17][ARM] Add tests for VFP FP16 ACLE instrinsics.
Date: Wed, 18 May 2016 01:07:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1605180104530.6325@digraph.polyomino.org.uk> (raw)
In-Reply-To: <573B2FC9.5070704@foss.arm.com>
On Tue, 17 May 2016, Matthew Wahab wrote:
> In some tests, there are unavoidable differences in precision when
> calculating the actual and the expected results of an FP16 operation. A
> new support function CHECK_FP_BIAS is used so that these tests can check
> for an acceptable margin of error. In these tests, the tolerance is
> given as the absolute integer difference between the bitvectors of the
> expected and the actual results.
As far as I can see, CHECK_FP_BIAS is only used in the following patch,
but there is another bias test in vsqrth_f16_1.c in this patch.
Could you clarify where the "unavoidable differences in precision" come
from? Are the results of some of the new instructions not fully
specified, only specified within a given precision? (As far as I can tell
the existing v8 instructions for reciprocal and reciprocal square root
estimates do have fully defined results, despite being loosely described
as esimtates.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-05-18 1:07 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 14:20 [PATCH 0/17][ARM] ARMv8.2-A and FP16 extension support Matthew Wahab
2016-05-17 14:23 ` [PATCH 1/17][ARM] Add ARMv8.2-A command line option and profile Matthew Wahab
2016-07-04 13:46 ` Matthew Wahab
2016-09-21 13:57 ` Ramana Radhakrishnan
2016-05-17 14:25 ` [PATCH 2/17][Testsuite] Add a selector for ARM FP16 alternative format support Matthew Wahab
2016-07-27 13:34 ` Ramana Radhakrishnan
2016-05-17 14:26 ` [PATCH 3/17][Testsuite] Add ARM support for ARMv8.2-A with FP16 arithmetic instructions Matthew Wahab
2016-07-04 13:49 ` Matthew Wahab
2016-07-27 13:34 ` Ramana Radhakrishnan
2016-05-17 14:28 ` [PATCH 4/17][ARM] Define feature macros for FP16 Matthew Wahab
2016-07-27 13:35 ` Ramana Radhakrishnan
2016-05-17 14:29 ` [PATCH 5/17][ARM] Enable HI mode moves for floating point values Matthew Wahab
2016-07-27 13:57 ` Ramana Radhakrishnan
2016-09-26 13:20 ` Christophe Lyon
2016-09-26 13:26 ` Matthew Wahab
2016-05-17 14:32 ` [PATCH 6/17][ARM] Add data processing intrinsics for float16_t Matthew Wahab
2016-07-27 13:59 ` Ramana Radhakrishnan
2016-09-25 14:44 ` Christophe Lyon
2016-09-26 9:56 ` Matthew Wahab
2016-09-26 12:54 ` Christophe Lyon
2016-09-26 13:11 ` Ramana Radhakrishnan
2016-09-26 13:19 ` Matthew Wahab
2016-09-26 13:21 ` Christophe Lyon
2016-09-26 20:02 ` Christophe Lyon
2016-05-17 14:34 ` [PATCH 7/17][ARM] Add FP16 data movement instructions Matthew Wahab
2016-07-04 13:57 ` Matthew Wahab
2016-07-27 14:01 ` Ramana Radhakrishnan
2016-05-17 14:36 ` [PATCH 8/17][ARM] Add VFP FP16 arithmetic instructions Matthew Wahab
2016-05-18 0:52 ` Joseph Myers
2016-05-18 0:57 ` Joseph Myers
2016-05-18 13:40 ` Matthew Wahab
2016-05-18 15:21 ` Joseph Myers
2016-05-19 14:54 ` Matthew Wahab
2016-07-04 14:02 ` Matthew Wahab
2016-07-28 11:37 ` Ramana Radhakrishnan
2016-08-03 11:52 ` Ramana Radhakrishnan
2016-08-03 13:10 ` Matthew Wahab
2016-08-03 14:45 ` James Greenhalgh
2016-08-03 17:44 ` Joseph Myers
2016-05-17 14:37 ` [PATCH 9/17][ARM] Add NEON " Matthew Wahab
2016-05-18 0:58 ` Joseph Myers
2016-05-19 17:01 ` Jiong Wang
2016-05-19 17:29 ` Joseph Myers
2016-06-08 8:46 ` James Greenhalgh
2016-06-08 20:02 ` Joseph Myers
2016-07-04 14:09 ` Matthew Wahab
2016-07-28 11:53 ` Ramana Radhakrishnan
2016-05-17 14:39 ` [PATCH 10/17][ARM] Refactor support code for NEON builtins Matthew Wahab
2016-07-28 11:54 ` Ramana Radhakrishnan
2016-12-05 16:47 ` [arm-embedded][committed][PATCH 10/17] " Andre Vieira (lists)
2016-05-17 14:41 ` [PATCH 11/17][ARM] Add builtins for VFP FP16 intrinsics Matthew Wahab
2016-07-04 14:12 ` Matthew Wahab
2016-07-28 11:55 ` Ramana Radhakrishnan
2016-05-17 14:43 ` [PATCH 12/17][ARM] Add builtins for NEON " Matthew Wahab
2016-07-04 14:13 ` Matthew Wahab
2016-07-28 11:56 ` Ramana Radhakrishnan
2016-05-17 14:44 ` [PATCH 13/17][ARM] Add VFP FP16 instrinsics Matthew Wahab
2016-07-04 14:14 ` Matthew Wahab
2016-07-28 11:57 ` Ramana Radhakrishnan
2016-05-17 14:47 ` [PATCH 14/17][ARM] Add NEON " Matthew Wahab
2016-07-04 14:16 ` Matthew Wahab
2016-08-03 12:57 ` Ramana Radhakrishnan
2016-05-17 14:49 ` [PATCH 15/17][ARM] Add tests for ARMv8.2-A FP16 support Matthew Wahab
2016-07-04 14:17 ` Matthew Wahab
2016-08-04 8:34 ` Ramana Radhakrishnan
2016-05-17 14:51 ` [PATCH 16/17][ARM] Add tests for VFP FP16 ACLE instrinsics Matthew Wahab
2016-05-18 1:07 ` Joseph Myers [this message]
2016-05-18 10:58 ` Matthew Wahab
2016-07-04 14:18 ` Matthew Wahab
2016-08-04 8:35 ` Ramana Radhakrishnan
2016-05-17 14:52 ` [PATCH 17/17][ARM] Add tests for NEON FP16 ACLE intrinsics Matthew Wahab
2016-07-04 14:22 ` Matthew Wahab
2016-08-04 9:01 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1605180104530.6325@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=matthew.wahab@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).