From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33248 invoked by alias); 27 Jun 2016 17:52:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33237 invoked by uid 89); 27 Jun 2016 17:52:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Initially, memcpy, remembering, goel X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 27 Jun 2016 17:52:40 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1bHai4-0006B9-BE from joseph_myers@mentor.com ; Mon, 27 Jun 2016 10:52:36 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Mon, 27 Jun 2016 18:50:46 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.86_2) (envelope-from ) id 1bHagH-0007VJ-4R; Mon, 27 Jun 2016 17:50:45 +0000 Date: Mon, 27 Jun 2016 18:02:00 -0000 From: Joseph Myers To: ayush goel CC: , =?ISO-8859-15?Q?Manuel_L=F3pez-Ib=E1=F1ez?= Subject: Re: Importing gnulib into the gcc tree In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-1086856276-1467049845=:7438" X-SW-Source: 2016-06/txt/msg01819.txt.bz2 ---1152306461-1086856276-1467049845=:7438 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-length: 833 On Sat, 25 Jun 2016, ayush goel wrote: > Initially I have just imported the bcopy module from gnulib which will > eventually replace gcc’s dependency on libiberty’s bcopy.  GCC should not depend on bcopy. Any bcopy use is a bug and it should be replaced by memcpy or memmove as appropriate. The poisoning in system.h should prevent such uses from building in the first place. You should only import gnulib modules for functionality actually used in GCC - remembering that GCC now depends on at least a C++98 compiler and library, so it's unlikely that modules for ISO C90 functionality are actually relevant on any currently supported host or build system. For example, GCC uses obstacks, so the gnulib version of obstack is appropriate to replace the libiberty version. -- Joseph S. Myers joseph@codesourcery.com ---1152306461-1086856276-1467049845=:7438--