From: Joseph Myers <joseph@codesourcery.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: nd <nd@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH 1/4][PR 71931] Fix libatomic tests
Date: Wed, 24 Aug 2016 22:08:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1608242207180.10883@digraph.polyomino.org.uk> (raw)
In-Reply-To: <57BDF021.6090207@arm.com>
On Wed, 24 Aug 2016, Szabolcs Nagy wrote:
> diff --git a/libatomic/testsuite/lib/libatomic.exp b/libatomic/testsuite/lib/libatomic.exp
> index cafab54..e374c64 100644
> --- a/libatomic/testsuite/lib/libatomic.exp
> +++ b/libatomic/testsuite/lib/libatomic.exp
> @@ -47,6 +47,8 @@ load_gcc_lib timeout.exp
> load_gcc_lib timeout-dg.exp
> load_gcc_lib fortran-modules.exp
>
> +load_file libatomic-test-support.exp
This approach looks like it would break installed testing. Such
information from the build tree should only be loaded when
TESTING_IN_BUILD_TREE is defined.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-08-24 22:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 19:04 [PATCH 0/4][PR 71931] Fix target lib tests --with-build-sysroot Szabolcs Nagy
2016-08-24 19:06 ` [PATCH 1/4][PR 71931] Fix libatomic tests Szabolcs Nagy
2016-08-24 22:08 ` Joseph Myers [this message]
2016-08-25 8:45 ` Szabolcs Nagy
2016-08-25 23:04 ` Joseph Myers
2016-08-24 19:07 ` [PATCH 2/4][PR 71931] Fix libgomp tests Szabolcs Nagy
2016-08-24 19:09 ` [PATCH 3/4][PR 71931] Fix libitm tests Szabolcs Nagy
2016-09-06 9:12 ` Torvald Riegel
2016-09-06 18:06 ` Mike Stump
2016-09-06 18:49 ` Szabolcs Nagy
2016-09-06 20:26 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1608242207180.10883@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=nd@arm.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).