From: Joseph Myers <joseph@codesourcery.com>
To: Martin Sebor <msebor@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] free MPFR caches in gimple-ssa-sprintf.c (PR 79699)
Date: Thu, 02 Mar 2017 01:01:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1703020100030.27707@digraph.polyomino.org.uk> (raw)
In-Reply-To: <60d46e1a-686b-9c27-4b48-7b658f8507fa@gmail.com>
On Wed, 1 Mar 2017, Martin Sebor wrote:
> Joseph, since you commented on the bug, do you have a suggestion
> for a different site for it or a guard? The only other call to
> the function is in the Fortran FE and it's neither guarded nor
> does it appear to ever be called.
I don't think a guard is needed. Arguably it should be called from an
atexit handler, but since we don't have such a handler calling it from the
relevant pass seems reasonable (and I'm not sure what the right way to
handle such freeing of memory in the JIT context is).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-03-02 1:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 23:32 Martin Sebor
2017-03-02 1:01 ` Joseph Myers [this message]
2017-03-02 8:08 ` Richard Biener
2017-03-02 21:34 ` Martin Sebor
2017-03-02 21:40 ` Andrew Pinski
2017-03-02 21:56 ` Martin Sebor
2017-03-03 11:02 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703020100030.27707@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).