From: Joseph Myers <joseph@codesourcery.com>
To: Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH, rs6000, committed] Fix gcc.target/powerpc/p8-vec-xl-xst.c target selector
Date: Mon, 22 May 2017 20:26:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1705222010061.9690@digraph.polyomino.org.uk> (raw)
In-Reply-To: <e0039e02-1a23-cdad-341c-187f1460f4f6@linux.vnet.ibm.com>
On Mon, 22 May 2017, Bill Schmidt wrote:
> Hi,
>
> The subject test requires little endian, but the target selector doesn't
> specify this. This patch fixes that. Tested on BE/LE P8 systems,
> committed as obvious.
It's not obvious; it's wrong. You can configure for a BE default while
supporting LE, using appropriate --enable-targets options. That's what
config/rs6000/t-linux64bele is for, for example. In such cases, this test
should be enabled when testing LE multilibs. Likewise, you can configure
for LE default while supporting BE, and then the test should be disabled
when testing BE multilibs.
For any target property that can depend on the multilib, you have to use a
general target pattern such as powerpc*-*-*, then test effective-target
keywords for any per-multilib properties that are relevant (such as
endianness in this case). Testing for BE/LE, or for 32-bit/64-bit, via
target triplet patterns, is always wrong in powerpc tests, just as it's
always wrong for x86 tests to support one of x86_64 and i?86 but not the
other (those should similarly use effective-targets as needed).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-05-22 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 20:14 Bill Schmidt
2017-05-22 20:26 ` Joseph Myers [this message]
2017-05-22 21:09 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1705222010061.9690@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).