From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87175 invoked by alias); 22 May 2017 20:14:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 86976 invoked by uid 89); 22 May 2017 20:14:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 May 2017 20:14:21 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1dCtif-0003nC-4a from joseph_myers@mentor.com ; Mon, 22 May 2017 13:14:21 -0700 Received: from digraph.polyomino.org.uk (137.202.0.87) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 22 May 2017 21:14:18 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.86_2) (envelope-from ) id 1dCtiX-0003Jb-3x; Mon, 22 May 2017 20:14:13 +0000 Date: Mon, 22 May 2017 20:26:00 -0000 From: Joseph Myers To: Bill Schmidt CC: GCC Patches , Segher Boessenkool Subject: Re: [PATCH, rs6000, committed] Fix gcc.target/powerpc/p8-vec-xl-xst.c target selector In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) X-SW-Source: 2017-05/txt/msg01705.txt.bz2 On Mon, 22 May 2017, Bill Schmidt wrote: > Hi, > > The subject test requires little endian, but the target selector doesn't > specify this. This patch fixes that. Tested on BE/LE P8 systems, > committed as obvious. It's not obvious; it's wrong. You can configure for a BE default while supporting LE, using appropriate --enable-targets options. That's what config/rs6000/t-linux64bele is for, for example. In such cases, this test should be enabled when testing LE multilibs. Likewise, you can configure for LE default while supporting BE, and then the test should be disabled when testing BE multilibs. For any target property that can depend on the multilib, you have to use a general target pattern such as powerpc*-*-*, then test effective-target keywords for any per-multilib properties that are relevant (such as endianness in this case). Testing for BE/LE, or for 32-bit/64-bit, via target triplet patterns, is always wrong in powerpc tests, just as it's always wrong for x86 tests to support one of x86_64 and i?86 but not the other (those should similarly use effective-targets as needed). -- Joseph S. Myers joseph@codesourcery.com