From: Joseph Myers <joseph@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Martin Sebor <msebor@gmail.com>, Jason Merrill <jason@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: RFC: [PATCH] Add warn_if_not_aligned attribute
Date: Thu, 15 Jun 2017 17:31:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1706151728020.3768@digraph.polyomino.org.uk> (raw)
In-Reply-To: <CAMe9rOp-X1S_HY70hr_-CO2HDvsDAJEw1FTMEj+CKS5Ds7C8-A@mail.gmail.com>
On Thu, 15 Jun 2017, H.J. Lu wrote:
> On Thu, Jun 15, 2017 at 8:38 AM, Martin Sebor <msebor@gmail.com> wrote:
> >>
> >> Where do we go from here?
> >
> >
> > Other than the C and C++ maintainers needing to approve the patch
> > I can't think of anything else.
>
> Hi Joseph, Jason,
>
> The complete patch is at
>
> https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00541.html
>
> Is this OK for trunk?
I'd expect the warning calls to include OPT_Wif_not_aligned or
OPT_Wpacked_not_aligned (as appropriate, depending on what triggered the
warning / would disable it), so the warning output includes an option
name.
As the attribute is specific to fields I'd expect testcases that use of it
on non-fields is diagnosed. And I think the diagnostic for that should
include quotes, %<warn_if_not_aligned%>.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-06-15 17:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 15:52 H.J. Lu
2017-06-05 15:11 ` Joseph Myers
2017-06-05 17:45 ` H.J. Lu
2017-06-06 16:07 ` Martin Sebor
2017-06-06 16:11 ` Martin Sebor
2017-06-06 16:59 ` H.J. Lu
2017-06-06 17:35 ` Martin Sebor
2017-06-06 22:57 ` H.J. Lu
2017-06-07 0:11 ` Martin Sebor
2017-06-07 13:30 ` H.J. Lu
2017-06-08 17:00 ` H.J. Lu
2017-06-08 19:13 ` Martin Sebor
2017-06-09 13:31 ` H.J. Lu
2017-06-15 15:38 ` Martin Sebor
2017-06-15 15:47 ` H.J. Lu
2017-06-15 17:31 ` Joseph Myers [this message]
2017-06-16 11:55 ` H.J. Lu
2017-07-06 15:45 ` Joseph Myers
2017-07-08 13:45 ` H.J. Lu
2017-08-17 14:19 ` Joseph Myers
2017-08-17 16:23 ` H.J. Lu
2017-08-18 1:40 ` Jason Merrill
2017-08-21 12:02 ` Szabolcs Nagy
2017-08-21 12:57 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1706151728020.3768@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jason@redhat.com \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).