From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28249 invoked by alias); 24 Jun 2017 19:47:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28237 invoked by uid 89); 24 Jun 2017 19:47:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mail3-relais-sop.national.inria.fr Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 24 Jun 2017 19:47:27 +0000 Received: from 91.70.140.77.rev.sfr.net (HELO stedding) ([77.140.70.91]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jun 2017 21:47:25 +0200 Date: Sat, 24 Jun 2017 19:47:00 -0000 From: Marc Glisse Reply-To: gcc-patches@gcc.gnu.org To: Andrew Pinski cc: GCC Patches Subject: Re: [PATCH] fold a * (a > 0 ? 1 : -1) to abs(a) and related optimizations In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-SW-Source: 2017-06/txt/msg01857.txt.bz2 On Sat, 24 Jun 2017, Andrew Pinski wrote: >> * if X is NaN, we may get a qNaN with the wrong sign bit. We probably don't >> care much though... > > Ok, I changed it to when not honoring NANs. Note that I have no idea what guarantees we give in gcc. It is quite possible that your patch is fine without this change, I only wanted to raise the question in case someone knows. -- Marc Glisse