From: Joseph Myers <joseph@codesourcery.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] C/C++: add fix-it hints for various missing symbols
Date: Wed, 05 Jul 2017 16:17:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1707051613590.7931@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1499268735.7656.131.camel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Wed, 5 Jul 2017, David Malcolm wrote:
> This error message might be better to be worded in terms of the
> syntactic thing that came before, which would yield:
>
> pr7356.c:1:2: error: expected â=â, â,â, â;â, âasmâ or â__attribute__â
> after declaration
> a//sample
> ^
>
> or somesuch. Doing so would presumably require adding an extra param to
> c_parser_error, e.g. an enum describing the syntactic elements that go before.
>
> Does this sound worth pursuing as a followup?
Yes. When you're wording things in terms of what the syntax error comes
after rather than saying it comes before some automatically-generated
description of a token, it would be best if the caller passes the complete
message in an i18n-friendly way, rather than using concat (bug 18248).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-07-05 16:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 18:04 David Malcolm
2017-07-03 18:57 ` Richard Sandiford
2017-07-03 19:34 ` David Malcolm
2017-07-11 14:09 ` [committed] diagnostics: support compact printing of secondary locations David Malcolm
2017-07-11 17:34 ` Richard Sandiford
2017-07-03 23:01 ` [PATCH] C/C++: add fix-it hints for various missing symbols Joseph Myers
2017-07-05 15:32 ` David Malcolm
2017-07-05 16:17 ` Joseph Myers [this message]
2017-08-28 16:11 ` Jeff Law
2017-09-26 13:56 ` [PATCH 0/2] " David Malcolm
2017-09-26 13:56 ` [PATCH 1/2] C++: avoid partial duplicate implementation of cp_parser_error David Malcolm
2017-10-11 17:26 ` PING: " David Malcolm
2017-10-11 21:21 ` Jason Merrill
2017-10-12 18:10 ` David Malcolm
2017-09-26 13:56 ` [PATCH 2/2] C/C++: add fix-it hints for various missing symbols (v2) David Malcolm
2017-10-05 16:08 ` [PATCH 2/2] C/C++: add fix-it hints for various missing symbols (v3) David Malcolm
2017-10-11 17:27 ` PING " David Malcolm
2017-10-12 5:23 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707051613590.7931@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).