From: Joseph Myers <joseph@codesourcery.com>
To: Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: C PATCH to detect clashing attributes (PR c/81544)
Date: Mon, 31 Jul 2017 22:33:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1707312228570.14802@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20170725153831.GG3397@redhat.com>
On Tue, 25 Jul 2017, Marek Polacek wrote:
> PR c/81544 complaints that we aren't detecting clashing noreturn /
> warn_unused_result attributes so this patch adds that checking. Martin
> plans to do more systematic checking in this area but meanwhile we
> might want to go with this.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
I'd expect exactly the same cases to be diagnosed for the two attributes
on the same declaration, in either order, whether or not inside a single
__attribute__, as are diagnosed when multiple declarations are involved
(this applies to all such cases of invalid attribute combinations, not
just this one). Whether or not this patch achieves this, the testcase
doesn't seem to cover the case of a single declaration with both
attributes (and I don't see an existing such test in c-c++-common or
gcc.dg either).
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2017-07-31 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 15:38 Marek Polacek
2017-07-31 22:33 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707312228570.14802@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).