From: Joseph Myers <joseph@codesourcery.com>
To: Ximin Luo <infinity0@pwned.gg>
Cc: Yury Gribov <tetra2005.patches@gmail.com>,
Matthias Klose <doko@debian.org>, Jeff Law <law@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PING^4][PATCH v2] Generate reproducible output independently of the build-path
Date: Fri, 11 Aug 2017 02:53:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1708102207240.8101@digraph.polyomino.org.uk> (raw)
In-Reply-To: <26de3a96-a923-93e4-ff1a-fbfa4844724d@pwned.gg>
On Thu, 10 Aug 2017, Ximin Luo wrote:
> Normally, system-wide CFLAGS etc are a static expression of policy. What I mean
> by that is, writing logic to determine CFLAGS for particular package, would
> "look like" the actual wording of that policy. So for example, "all packages
> should have debug" => "CFLAGS+=-g", "packages that match property X should have
> flag Y" => "if X then CFLAGS += Y". OTOH if your policy is "packages should be
> reproducible" and we have to add these prefix-remapping flags to CFLAGS, you're
> adding a dependency from the value of CFLAGS itself, onto the build-time
> filesystem. So CFLAGS is no longer a static expression of policy, it depends on
> information not part of the policy.
>
> So, prefix-map is really different from other CFLAGS, it adds extra dependency
> relationships that other flags don't add.
I think the difference is essentially that these options belong in CC not
CFLAGS (CFLAGS is for non-semantic options, CC should include any options
that are required in every compilation).
(FWIW, I support having the environment variable, but think there should
be some command-line option exactly equivalent to it.)
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2017-08-10 22:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 16:16 Ximin Luo
2017-07-21 16:16 ` [PATCH 3/3] When remapping paths, only match whole path components Ximin Luo
2017-07-21 16:16 ` [PATCH 2/3] Use BUILD_PATH_PREFIX_MAP envvar to transform __FILE__ Ximin Luo
2017-07-21 16:16 ` [PATCH 1/3] Use BUILD_PATH_PREFIX_MAP envvar for debug-prefix-map Ximin Luo
2017-08-02 19:19 ` Jeff Law
2017-08-02 19:09 ` [PING^4][PATCH v2] Generate reproducible output independently of the build-path Jeff Law
2017-08-03 2:06 ` Ximin Luo
2017-08-03 4:49 ` Yury Gribov
2017-08-03 11:46 ` Ximin Luo
2017-08-04 8:40 ` Yury Gribov
2017-08-10 21:29 ` Ximin Luo
2017-08-03 15:57 ` Jeff Law
2017-08-03 16:05 ` Jeff Law
2017-08-03 17:02 ` Ximin Luo
2017-08-04 12:32 ` Matthias Klose
2017-08-04 13:05 ` Jakub Jelinek
2017-08-10 21:15 ` Ximin Luo
2017-08-04 16:05 ` Yury Gribov
2017-08-10 20:55 ` Ximin Luo
2017-08-11 2:53 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1708102207240.8101@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=doko@debian.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=infinity0@pwned.gg \
--cc=law@redhat.com \
--cc=tetra2005.patches@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).