From: Joseph Myers <joseph@codesourcery.com>
To: Michael Meissner <meissner@linux.vnet.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH, version 2], Add support for _Float<N> and _Float<N>X sqrt, fma, fmin, fmax built-in functions
Date: Thu, 19 Oct 2017 23:00:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1710192211280.9397@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20171019220831.GA27658@ibm-tiger.the-meissners.org>
On Thu, 19 Oct 2017, Michael Meissner wrote:
> 1) I switched to use DEF_EXT_LIB_BUILTIN to declare the _Float<N> and
> _Float<N>X functions. This allows treating __builtin_sqrtf128 the same
> as sqrtf128.
It's not correct to do that unconditionally for all the existing
DEF_GCC_FLOATN_NX_BUILTINS functions. There should not be a public
huge_valf128 function any more than a public huge_val function, just
__builtin_huge_valf128.
Rather, you should add a new DEF_EXT_LIB_FLOATN_NX_BUILTINS. It should be
used by the new functions, and by the existing copysign / fabs / nan
functions. It should not be used by the existing huge_val / inf / nans
functions.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-10-19 22:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 21:46 [PATCH], Add support for __builtin_{sqrt,fma}f128 on PowerPC ISA 3.0 Michael Meissner
2017-09-13 22:49 ` Joseph Myers
2017-09-14 19:02 ` Michael Meissner
2017-10-19 22:15 ` [PATCH, version 2], Add support for _Float<N> and _Float<N>X sqrt, fma, fmin, fmax built-in functions Michael Meissner
2017-10-19 23:00 ` Joseph Myers [this message]
2017-10-19 23:00 ` Michael Meissner
2017-10-19 23:08 ` Joseph Myers
2017-10-24 22:40 ` [PATCH, version 3], " Michael Meissner
2017-10-24 23:13 ` Joseph Myers
2017-10-24 23:58 ` Michael Meissner
2017-10-25 19:25 ` [PATCH, version 4], " Michael Meissner
2017-10-25 20:01 ` Michael Meissner
2017-10-25 20:11 ` Joseph Myers
2017-10-25 20:31 ` Michael Meissner
2017-10-25 20:50 ` Joseph Myers
2017-10-25 23:37 ` [PATCH, version 5], " Michael Meissner
2017-10-25 23:56 ` Joseph Myers
2017-10-26 0:04 ` [PATCH, version 5a], " Michael Meissner
2017-10-26 0:17 ` Michael Meissner
2017-10-30 16:29 ` Joseph Myers
2017-10-30 18:05 ` Michael Meissner
2017-10-30 18:38 ` Joseph Myers
2017-10-30 23:06 ` Michael Meissner
2017-10-30 23:29 ` Michael Meissner
2017-10-30 23:35 ` Joseph Myers
2017-10-30 23:48 ` Michael Meissner
2017-10-31 18:04 ` Michael Meissner
2017-10-31 18:26 ` Joseph Myers
2017-10-27 2:27 ` Segher Boessenkool
2017-09-14 14:54 ` [PATCH], Add support for __builtin_{sqrt,fma}f128 on PowerPC ISA 3.0 Segher Boessenkool
2017-09-14 22:21 ` Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710192211280.9397@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.vnet.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).