From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67532 invoked by alias); 19 Oct 2017 22:15:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67517 invoked by uid 89); 19 Oct 2017 22:15:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:809 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Oct 2017 22:15:54 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1e5J6V-0007dx-9t from joseph_myers@mentor.com ; Thu, 19 Oct 2017 15:15:51 -0700 Received: from digraph.polyomino.org.uk (137.202.0.87) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Thu, 19 Oct 2017 23:15:47 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.86_2) (envelope-from ) id 1e5J6O-0003YN-DD; Thu, 19 Oct 2017 22:15:44 +0000 Date: Thu, 19 Oct 2017 23:00:00 -0000 From: Joseph Myers To: Michael Meissner CC: GCC Patches , Segher Boessenkool , David Edelsohn , Bill Schmidt Subject: Re: [PATCH, version 2], Add support for _Float and _FloatX sqrt, fma, fmin, fmax built-in functions In-Reply-To: <20171019220831.GA27658@ibm-tiger.the-meissners.org> Message-ID: References: <20170913214600.GA24598@ibm-tiger.the-meissners.org> <20171019220831.GA27658@ibm-tiger.the-meissners.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2017-10/txt/msg01303.txt.bz2 On Thu, 19 Oct 2017, Michael Meissner wrote: > 1) I switched to use DEF_EXT_LIB_BUILTIN to declare the _Float and > _FloatX functions. This allows treating __builtin_sqrtf128 the same > as sqrtf128. It's not correct to do that unconditionally for all the existing DEF_GCC_FLOATN_NX_BUILTINS functions. There should not be a public huge_valf128 function any more than a public huge_val function, just __builtin_huge_valf128. Rather, you should add a new DEF_EXT_LIB_FLOATN_NX_BUILTINS. It should be used by the new functions, and by the existing copysign / fabs / nan functions. It should not be used by the existing huge_val / inf / nans functions. -- Joseph S. Myers joseph@codesourcery.com