From: Joseph Myers <joseph@codesourcery.com>
To: Michael Meissner <meissner@linux.vnet.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH, version 4], Add support for _Float<N> and _Float<N>X sqrt, fma, fmin, fmax built-in functions
Date: Wed, 25 Oct 2017 20:11:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1710252007310.18935@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20171025191243.GA1434@ibm-tiger.the-meissners.org>
On Wed, 25 Oct 2017, Michael Meissner wrote:
> +static const char *const fltfn_suffixes[] = { "F16", "F32", "F128", "F32X",
> + "F64X", "F128X", NULL };
I'd expect this to include F64. If there's some reason that's
inappropriate and the omission is deliberate, it needs a detailed comment
explaining the omission.
I don't think that, given the availability of fmaf128 etc. built-in
functions with appropriate options, whether __FP_FAST_* are defined should
actually depend on whether the user has passed options to disable those
functions (after all, it doesn't for the existing fma / fmaf / fmal, and
individual built-in functions can be disabled with -fno-builtin-<function>
so the logic you have wouldn't work to detect whether the built-in
function is disabled anyway).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-10-25 20:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 21:46 [PATCH], Add support for __builtin_{sqrt,fma}f128 on PowerPC ISA 3.0 Michael Meissner
2017-09-13 22:49 ` Joseph Myers
2017-09-14 19:02 ` Michael Meissner
2017-10-19 22:15 ` [PATCH, version 2], Add support for _Float<N> and _Float<N>X sqrt, fma, fmin, fmax built-in functions Michael Meissner
2017-10-19 23:00 ` Joseph Myers
2017-10-19 23:00 ` Michael Meissner
2017-10-19 23:08 ` Joseph Myers
2017-10-24 22:40 ` [PATCH, version 3], " Michael Meissner
2017-10-24 23:13 ` Joseph Myers
2017-10-24 23:58 ` Michael Meissner
2017-10-25 19:25 ` [PATCH, version 4], " Michael Meissner
2017-10-25 20:01 ` Michael Meissner
2017-10-25 20:11 ` Joseph Myers [this message]
2017-10-25 20:31 ` Michael Meissner
2017-10-25 20:50 ` Joseph Myers
2017-10-25 23:37 ` [PATCH, version 5], " Michael Meissner
2017-10-25 23:56 ` Joseph Myers
2017-10-26 0:04 ` [PATCH, version 5a], " Michael Meissner
2017-10-26 0:17 ` Michael Meissner
2017-10-30 16:29 ` Joseph Myers
2017-10-30 18:05 ` Michael Meissner
2017-10-30 18:38 ` Joseph Myers
2017-10-30 23:06 ` Michael Meissner
2017-10-30 23:29 ` Michael Meissner
2017-10-30 23:35 ` Joseph Myers
2017-10-30 23:48 ` Michael Meissner
2017-10-31 18:04 ` Michael Meissner
2017-10-31 18:26 ` Joseph Myers
2017-10-27 2:27 ` Segher Boessenkool
2017-09-14 14:54 ` [PATCH], Add support for __builtin_{sqrt,fma}f128 on PowerPC ISA 3.0 Segher Boessenkool
2017-09-14 22:21 ` Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710252007310.18935@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.vnet.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).