From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-465119-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 5254 invoked by alias); 25 Oct 2017 20:10:56 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 5243 invoked by uid 89); 25 Oct 2017 20:10:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Oct 2017 20:10:55 +0000
Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com)	by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256)	id 1e7S0p-0003Ed-Oq from joseph_myers@mentor.com ; Wed, 25 Oct 2017 13:10:51 -0700
Received: from digraph.polyomino.org.uk (137.202.0.87) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 25 Oct 2017 21:10:48 +0100
Received: from jsm28 (helo=localhost)	by digraph.polyomino.org.uk with local-esmtp (Exim 4.86_2)	(envelope-from <joseph@codesourcery.com>)	id 1e7S0j-00058q-57; Wed, 25 Oct 2017 20:10:45 +0000
Date: Wed, 25 Oct 2017 20:11:00 -0000
From: Joseph Myers <joseph@codesourcery.com>
To: Michael Meissner <meissner@linux.vnet.ibm.com>
CC: GCC Patches <gcc-patches@gcc.gnu.org>, Segher Boessenkool	<segher@kernel.crashing.org>, David Edelsohn <dje.gcc@gmail.com>, Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH, version 4], Add support for _Float<N> and _Float<N>X sqrt, fma, fmin, fmax built-in functions
In-Reply-To: <20171025191243.GA1434@ibm-tiger.the-meissners.org>
Message-ID: <alpine.DEB.2.20.1710252007310.18935@digraph.polyomino.org.uk>
References: <20170913214600.GA24598@ibm-tiger.the-meissners.org> <alpine.DEB.2.20.1709132239500.28319@digraph.polyomino.org.uk> <20171019220831.GA27658@ibm-tiger.the-meissners.org> <alpine.DEB.2.20.1710192211280.9397@digraph.polyomino.org.uk> <20171024221900.GA24351@ibm-tiger.the-meissners.org> <alpine.DEB.2.20.1710242300560.8054@digraph.polyomino.org.uk> <20171025191243.GA1434@ibm-tiger.the-meissners.org>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3)
X-SW-Source: 2017-10/txt/msg01844.txt.bz2

On Wed, 25 Oct 2017, Michael Meissner wrote:

> +static const char *const fltfn_suffixes[] = { "F16", "F32", "F128", "F32X",
> +                                             "F64X", "F128X", NULL };

I'd expect this to include F64.  If there's some reason that's 
inappropriate and the omission is deliberate, it needs a detailed comment 
explaining the omission.

I don't think that, given the availability of fmaf128 etc. built-in 
functions with appropriate options, whether __FP_FAST_* are defined should 
actually depend on whether the user has passed options to disable those 
functions (after all, it doesn't for the existing fma / fmaf / fmal, and 
individual built-in functions can be disabled with -fno-builtin-<function> 
so the logic you have wouldn't work to detect whether the built-in 
function is disabled anyway).

-- 
Joseph S. Myers
joseph@codesourcery.com