From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96986 invoked by alias); 30 Oct 2017 23:30:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 96919 invoked by uid 89); 30 Oct 2017 23:30:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:827 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Oct 2017 23:30:23 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1e9JVb-0005uY-2D from joseph_myers@mentor.com ; Mon, 30 Oct 2017 16:30:19 -0700 Received: from digraph.polyomino.org.uk (137.202.0.87) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 30 Oct 2017 23:30:16 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.86_2) (envelope-from ) id 1e9JVU-0005RN-IQ; Mon, 30 Oct 2017 23:30:12 +0000 Date: Mon, 30 Oct 2017 23:35:00 -0000 From: Joseph Myers To: Michael Meissner CC: GCC Patches , Segher Boessenkool , David Edelsohn , Bill Schmidt Subject: Re: [PATCH, version 5a], Add support for _Float and _FloatX sqrt, fma, fmin, fmax built-in functions In-Reply-To: <20171030225734.GA450@ibm-tiger.the-meissners.org> Message-ID: References: <20171025202736.GA18058@ibm-tiger.the-meissners.org> <20171025224724.GA25269@ibm-tiger.the-meissners.org> <20171025235709.GA8932@ibm-tiger.the-meissners.org> <20171026001118.GA11364@ibm-tiger.the-meissners.org> <20171030180507.GA14054@ibm-tiger.the-meissners.org> <20171030225734.GA450@ibm-tiger.the-meissners.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-SW-Source: 2017-10/txt/msg02264.txt.bz2 On Mon, 30 Oct 2017, Michael Meissner wrote: > This patch fixes exporting the non __builtin_ names to be done by default only > for the C language. I added a target hook in case a port needs to enable > built-ins for C++ (either wholesale, or for particular built-in functions). Testing lang_GNU_C () can't possibly be correct here; ObjC should always be handled like C unless there is a strong reason not to do so, explicitly commented. Also, I'd expect the FALLBACK_P argument to DEF_BUILTIN to be true, not a call to the hook; __builtin_sqrtf128 should always end up generating a call to the out-of-line sqrtf128 function if not inlined, regardless of source language. -- Joseph S. Myers joseph@codesourcery.com