* Update comment in tree-vrp.h
@ 2017-11-05 18:15 Marc Glisse
2017-11-06 11:46 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Marc Glisse @ 2017-11-05 18:15 UTC (permalink / raw)
To: gcc-patches
Hello,
looking at the history, it seems that this comment should be updated as in
the following patch (the definition of struct value_range is right below
and explains VR_RANGE and VR_ANTI_RANGE). I am not committing this as
obvious because the text below does *not* actually describe VR_VARYING or
VR_UNDEFINED, and while I know what VR_VARYING means, I am still confused
by VR_UNDEFINED, so cannot write that comment myself.
--- tree-vrp.h (revision 254429)
+++ tree-vrp.h (working copy)
@@ -20,7 +20,7 @@ along with GCC; see the file COPYING3.
#ifndef GCC_TREE_VRP_H
#define GCC_TREE_VRP_H
-/* Type of value ranges. See value_range_d In tree-vrp.c for a
+/* Type of value ranges. See value_range below for a
description of these types. */
enum value_range_type { VR_UNDEFINED, VR_RANGE,
VR_ANTI_RANGE, VR_VARYING, VR_LAST };
2017-11-06 Marc Glisse <marc.glisse@inria.fr>
* tree-vrp.h (enum value_range_type): Update stale comment.
--
Marc Glisse
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Update comment in tree-vrp.h
2017-11-05 18:15 Update comment in tree-vrp.h Marc Glisse
@ 2017-11-06 11:46 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2017-11-06 11:46 UTC (permalink / raw)
To: Marc Glisse; +Cc: GCC Patches
On Sun, Nov 5, 2017 at 7:15 PM, Marc Glisse <marc.glisse@inria.fr> wrote:
> Hello,
>
> looking at the history, it seems that this comment should be updated as in
> the following patch (the definition of struct value_range is right below and
> explains VR_RANGE and VR_ANTI_RANGE). I am not committing this as obvious
> because the text below does *not* actually describe VR_VARYING or
> VR_UNDEFINED, and while I know what VR_VARYING means, I am still confused by
> VR_UNDEFINED, so cannot write that comment myself.
Patch is ok anyway. I think VR_UNDEFINED maps to "uninitialized" in C terms.
The corresponding CCP lattice doesn't have a too precise definition either
(and also includes UNINITIALIZED...)
Richard.
> --- tree-vrp.h (revision 254429)
> +++ tree-vrp.h (working copy)
> @@ -20,7 +20,7 @@ along with GCC; see the file COPYING3.
> #ifndef GCC_TREE_VRP_H
> #define GCC_TREE_VRP_H
>
> -/* Type of value ranges. See value_range_d In tree-vrp.c for a
> +/* Type of value ranges. See value_range below for a
> description of these types. */
> enum value_range_type { VR_UNDEFINED, VR_RANGE,
> VR_ANTI_RANGE, VR_VARYING, VR_LAST };
>
>
> 2017-11-06 Marc Glisse <marc.glisse@inria.fr>
>
> * tree-vrp.h (enum value_range_type): Update stale comment.
>
> --
> Marc Glisse
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-06 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-05 18:15 Update comment in tree-vrp.h Marc Glisse
2017-11-06 11:46 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).