From: Joseph Myers <joseph@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, Marek Polacek <polacek@redhat.com>,
Jason Merrill <jason@redhat.com>, Nathan Sidwell <nathan@acm.org>,
<gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix -traditional-cpp preprocessing ICE (PR preprocessor/69869)
Date: Wed, 31 Jan 2018 05:35:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1801310015110.1617@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180130225036.GI2063@tucnak>
On Tue, 30 Jan 2018, Jakub Jelinek wrote:
> Hi!
>
> This restores GCC 3.3 behavior on this testcase, before 3.4 started ICEing
> on it when it started to use the common block comment skipping code for
> -traditional-cpp and just a simple function for macro block comments has
> been added. Even the macro block comments can be not properly terminated
> and we shouldn't crash on that, just diagnose it.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
OK with the comment on skip_macro_block_comment updated to document the
semantics of the return value.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2018-01-31 0:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 23:25 Jakub Jelinek
2018-01-31 5:35 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801310015110.1617@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=nathan@acm.org \
--cc=polacek@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).