public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	Jason Merrill <jason@redhat.com>,
	Richard Earnshaw <Richard.Earnshaw@arm.com>, <rth@twiddle.net>,
	<gnu@amylaar.uk>, Nick Clifton <nickc@redhat.com>,
	<chertykov@gmail.com>,	<jzhang918@gmail.com>,
	Bernd Schmidt <bernds_cb1@t-online.de>, <hp@axis.com>,
	<james.bowman@ftdichip.com>, Jeff Law <law@redhat.com>,
	Jan Hubicka	<hubicka@ucw.cz>, Jim Wilson <wilson@tuliptree.org>,
	<sebastien@milkymist.org>, <eager@eagercon.com>,
	<clm@codesourcery.com>,	<green@moxielogic.com>,
	<jasonwucj@gmail.com>, <cltang@codesourcery.com>,
	<tom@codesourcery.com>, <ni1d@arrl.net>, <kito.cheng@gmail.com>,
	<dj@redhat.com>, David Edelsohn <dje.gcc@gmail.com>,
	<hepenner@us.ibm.com>,	Alexandre Oliva <aoliva@redhat.com>,
	<davem@redhat.com>, <walt@tilera.com>,	<matt@3am-software.com>,
	<ebotcazou@libertysurf.fr>,	<augustine.sterling@gmail.com>
Subject: Re: Deprecate not defining NO_IMPLICIT_EXTERN_C
Date: Wed, 21 Mar 2018 21:33:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.20.1803212119020.3411@digraph.polyomino.org.uk> (raw)
In-Reply-To: <18ff217b-e10b-008b-fb26-bb0cb018b10f@acm.org>

On Wed, 21 Mar 2018, Nathan Sidwell wrote:

> Unfortunately it's a negative-sense define, that now at least most ports
> define.  Do all ports define it?  It's hard to determine that, because many
> ports get it set via config/gnu-user.h or similar common file.

Bare-metal ports often fail to define it.

As far as I know, newlib headers at least do not require implicit extern 
C.  If there are any that are missing explicit extern C, I'd rather that 
was addressed by (a) fixing them and (b) adding fixes in fixincludes if we 
wish to work with older header versions.

My list from 2005 of targets not defining NO_IMPLICIT_EXTERN_C then is 
<https://gcc.gnu.org/ml/gcc/2005-05/msg00377.html>.

I think this should become a target hook, where the default is 
implicit_extern_c returning false and only AIX (and any other OSes 
requiring it) sets the hook to return true.

> It also has the following undocumented features (when not set):

Whether these are needed would depend on the properties of headers for 
OSes setting the hook to return true.  Even if needed, one might consider 
fixing such header issues with fixincludes as a replacement for those 
features in the compiler.

-- 
Joseph S. Myers
joseph@codesourcery.com

  parent reply	other threads:[~2018-03-21 21:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 12:32 Nathan Sidwell
2018-03-21 14:18 ` Richard Earnshaw (lists)
2018-03-21 14:38 ` David Edelsohn
2018-03-21 15:42   ` Nathan Sidwell
2018-03-21 21:33 ` Joseph Myers [this message]
2018-03-22 12:16   ` Nathan Sidwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1803212119020.3411@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=aoliva@redhat.com \
    --cc=augustine.sterling@gmail.com \
    --cc=bernds_cb1@t-online.de \
    --cc=chertykov@gmail.com \
    --cc=clm@codesourcery.com \
    --cc=cltang@codesourcery.com \
    --cc=davem@redhat.com \
    --cc=dj@redhat.com \
    --cc=dje.gcc@gmail.com \
    --cc=eager@eagercon.com \
    --cc=ebotcazou@libertysurf.fr \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu@amylaar.uk \
    --cc=green@moxielogic.com \
    --cc=hepenner@us.ibm.com \
    --cc=hp@axis.com \
    --cc=hubicka@ucw.cz \
    --cc=james.bowman@ftdichip.com \
    --cc=jason@redhat.com \
    --cc=jasonwucj@gmail.com \
    --cc=jzhang918@gmail.com \
    --cc=kito.cheng@gmail.com \
    --cc=law@redhat.com \
    --cc=matt@3am-software.com \
    --cc=nathan@acm.org \
    --cc=ni1d@arrl.net \
    --cc=nickc@redhat.com \
    --cc=rth@twiddle.net \
    --cc=sebastien@milkymist.org \
    --cc=tom@codesourcery.com \
    --cc=walt@tilera.com \
    --cc=wilson@tuliptree.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).