From: Joseph Myers <joseph@codesourcery.com>
To: Alexander von Gluck IV <kallisti5@unixzen.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] haiku: Initial build support
Date: Thu, 26 Jul 2018 17:26:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1807261712010.25831@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180717012715.26131-1-kallisti5@unixzen.com>
[-- Attachment #1: Type: text/plain, Size: 2627 bytes --]
On Mon, 16 Jul 2018, Alexander von Gluck IV wrote:
> * We have been dragging these around since gcc 4.x.
> * Some tweaks will likely be needed, but this gets our foot
> in the door.
>
> Authors:
> Fredrik Holmqvist
> Jerome Duval
> Augustin Cavalier
> François Revol
> Simon South
> Jessica Hamilton
> Ithamar R. Adema
> Oliver Tappe
> Jonathan Schleifer
> .. and maybe more!
Before this can be reviewed, we'll need copyright assignments (with
employer disclaimers where applicable) on file at the FSF from everyone
who contributed a legally significant amount of code (more than around 15
lines). Without those, reviewers can't safely look at the changes in
detail.
https://gcc.gnu.org/contribute.html
https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future
Then, please make sure that only substantive changes are included - that
there are no diff lines that are purely changing trailing whitespace in
existing code, for example. Please ensure that all copyright and license
notices follow current standards (which means using ranges of years ending
in 2018, GPLv3 notices and a URL not an FSF postal address). For changes
to existing code, especially, please make sure to include sufficient
rationale in the patch submission to explain those changes, why they are
needed and the approach taken to them.
For new target OS support, I'd expect details to be provided of the test
results on that OS for the various architectures supported by GCC. Are
you planning, if the support is accepted in GCC, to maintain a bot that
keeps running the GCC testsuite for GCC mainline for this OS for the
various target architectures supported, at least daily or thereabouts, and
posts the results to the gcc-testresults list, and to keep monitoring the
test results and fixing OS-specific issues that show up? It's much better
for issues to be identified within a day or two of the commit causing them
than many months later, possibly only after a release has come out with
the issue - but that requires an ongoing commitment to keep monitoring
test results, posting them to gcc-testresults and keeping them in good
shape.
> diff --git a/libtool.m4 b/libtool.m4
If this an exact backport of a change from upstream libtool git? If so,
please give the commit reference. If not, give the URL of the submission
to upstream libtool. We don't want local libtool changes that aren't
backports or at least proposed upstream without objections, to avoid
making future updates from upstream libtool harder.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-07-26 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 1:27 Alexander von Gluck IV
2018-07-26 17:26 ` Joseph Myers [this message]
2018-07-27 11:59 ` Ramana Radhakrishnan
2018-07-27 17:05 ` Joseph Myers
2018-07-27 13:08 ` Alexander von Gluck IV
2018-07-27 17:22 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1807261712010.25831@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kallisti5@unixzen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).