From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18520 invoked by alias); 27 Jul 2018 17:22:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18479 invoked by uid 89); 27 Jul 2018 17:22:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=glance, images X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Jul 2018 17:22:26 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1fj6Rc-0004zd-6b from joseph_myers@mentor.com ; Fri, 27 Jul 2018 10:22:24 -0700 Received: from digraph.polyomino.org.uk (137.202.0.87) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 27 Jul 2018 18:22:20 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.86_2) (envelope-from ) id 1fj6RX-0006BH-VO; Fri, 27 Jul 2018 17:22:19 +0000 Date: Fri, 27 Jul 2018 17:22:00 -0000 From: Joseph Myers To: Alexander von Gluck IV CC: Ramana Radhakrishnan , gcc-patches Subject: Re: [PATCH] haiku: Initial build support In-Reply-To: <28eea502b237482cb9f550743e2166d6@unixzen.com> Message-ID: References: <20180717012715.26131-1-kallisti5@unixzen.com> <28eea502b237482cb9f550743e2166d6@unixzen.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2018-07/txt/msg01750.txt.bz2 On Fri, 27 Jul 2018, Alexander von Gluck IV wrote: > >> It's much better for issues to be identified within a day or two of the > >> commit causing them than many months later, possibly only after a release > >> has come out with the issue - but that requires an ongoing commitment to > >> keep monitoring test results, posting them to gcc-testresults and keeping > >> them in good shape. > > This is good information, however, does GCC have docs for this? We are a > small team of open source developers with maybe a few man-hours a month > available to dedicate to gcc maintainership. (no excuses, just trying > to set the expectations) Well, install.texi documents the use of contrib/test_summary to post test results. I think the documentation is better for one-off requirements for a patch, than for expectations for maintainers on an ongoing basis (in that maintainers would typically have been following development for some time, and so have seen what maintainers of other architectures and OSes do - for example, have seen how AIX people promptly raise issues when a patch breaks things for AIX, which is the sort of thing I'd expect target OS maintainers to do in general). > These steps seem like what's needed on a first-class platform (Linux, OS X, > etc). So the same requirements apply to all new GCC platforms code? Requirements for OS and architecture ports aren't well-defined and seem like a good topic for Cauldron discussion. But generically, it's important that new architecture and OS ports don't get in the way of global changes. This means it's important to have sufficient documentation available for architectures for the use of people doing global changes, that it's valuable to have simulators (with OS images as applicable) with information (e.g. DejaGnu board files) available for people wishing to test on the architecture or OS (or hardware systems available in the GCC Compile Farm, for architectures and OSes for which that works better), and that it's valuable if people can tell at a glance at recent gcc-testresults posts what shape the port is in. And, as a matter of working well with other developers, it's much better to find and point out breakage promptly rather than long after the patch that broke something went in (and, in particular, in the same development stage; if there's a design issue with a patch going in during stage 1 which requires design changes for some architectures or OSes, it's very unhelpful if that's only found much later when trunk is in regression-fixes-only mode for the next release). Also, unmaintained features and unused ports are liable to be removed, and having test results posted is important evidence of whether the port is in good shape or should be considered for removal. -- Joseph S. Myers joseph@codesourcery.com