public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Marek Polacek <polacek@redhat.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: [C PATCH] Fix endless loop in the C FE initializer handling (PR c/85704)
Date: Tue, 31 Jul 2018 20:05:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.20.1807312004130.2939@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180724085756.GB17988@tucnak>

On Tue, 24 Jul 2018, Jakub Jelinek wrote:

> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk and
> release branches?
> 
> 2018-07-24  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR c/85704
> 	* c-typeck.c (field_decl_cmp): New function.
> 	(output_pending_init_elements): Use it for field comparisons
> 	instead of pure bit_position comparisons.
> 
> 	* gcc.c-torture/compile/pr85704.c: New test.

OK, though I'm a bit uneasy about both c-decl.c and c-typeck.c having 
static field_decl_cmp functions that do completely different comparisons.

-- 
Joseph S. Myers
joseph@codesourcery.com

  parent reply	other threads:[~2018-07-31 20:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24  8:58 Jakub Jelinek
2018-07-31 10:22 ` Patch ping (Re: [C PATCH] Fix endless loop in the C FE initializer handling (PR c/85704)) Jakub Jelinek
2018-07-31 20:05 ` Joseph Myers [this message]
2018-07-31 20:09   ` [C PATCH] Fix endless loop in the C FE initializer handling (PR c/85704) Jakub Jelinek
2018-07-31 20:11     ` Joseph Myers
2019-03-21 10:13 ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1807312004130.2939@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=polacek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).