From: Joseph Myers <joseph@codesourcery.com>
To: Martin Sebor <msebor@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>
Subject: Re: [PATCH] convert braced initializers to strings (PR 71625)
Date: Tue, 07 Aug 2018 11:31:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1808071129010.30891@digraph.polyomino.org.uk> (raw)
In-Reply-To: <3972f96d-1030-6e84-148a-ff270d0b88fe@gmail.com>
On Tue, 7 Aug 2018, Martin Sebor wrote:
> 2) skipping embedded nuls made it possible to create a string
> with fewer elements than the initializer array, which caused
> arrays with unspecified bound to be smaller than they would
> have been otherwise
I think there should be explicit tests of sizeof for arrays with
unspecified bound - to make sure both that it isn't any smaller than it
should be, but also that any NULs implicitly added for a STRING_CST don't
make the arrays any larger than their size should be for the originally
given initializer that doesn't have a 0 as the last element.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-08-07 11:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 23:51 Martin Sebor
2018-07-31 13:39 ` Jason Merrill
2018-07-31 14:49 ` Martin Sebor
2018-08-07 8:58 ` Jason Merrill
2018-08-07 23:04 ` Martin Sebor
2018-08-08 11:09 ` Jason Merrill
2018-08-09 0:17 ` Martin Sebor
2018-08-09 22:07 ` Joseph Myers
2018-08-13 10:36 ` Jason Merrill
2018-08-14 13:27 ` James Greenhalgh
2018-08-14 15:08 ` Martin Sebor
2018-08-14 15:24 ` Martin Sebor
2018-08-15 2:34 ` Martin Sebor
2018-08-15 10:29 ` James Greenhalgh
2018-08-15 15:04 ` Richard Biener
2018-08-15 15:51 ` Martin Sebor
2018-08-17 17:19 ` [PATCH] Fix poly types after PR tree-optimization/71625 strlen optimization Szabolcs Nagy
2018-08-17 17:22 ` Kyrill Tkachov
2018-08-14 21:14 ` [PATCH] convert braced initializers to strings (PR 71625) Joseph Myers
2018-08-14 22:18 ` Martin Sebor
2018-08-15 12:07 ` Joseph Myers
2018-08-15 21:02 ` Martin Sebor
2018-08-15 21:14 ` Jeff Law
2018-08-15 21:34 ` Jeff Law
2018-08-16 15:23 ` Martin Sebor
2018-08-16 15:32 ` Jeff Law
2018-08-06 16:41 ` Martin Sebor
2018-08-06 17:04 ` Joseph Myers
2018-08-07 2:02 ` Martin Sebor
2018-08-07 11:31 ` Joseph Myers [this message]
2018-08-07 23:05 ` Martin Sebor
2018-08-08 17:33 Bernd Edlinger
2018-08-08 18:34 ` Bernd Edlinger
2018-08-08 19:50 ` Martin Sebor
2018-08-08 20:35 ` Bernd Edlinger
2018-08-08 20:48 ` Joseph Myers
2018-08-09 0:23 ` Martin Sebor
2018-08-09 10:47 ` Joseph Myers
2018-08-16 6:37 Bernd Edlinger
2018-08-17 22:26 ` Bernd Edlinger
2018-08-18 4:13 ` Jeff Law
2018-08-18 10:40 ` Richard Sandiford
2018-08-18 14:25 ` Bernd Edlinger
2018-08-18 16:46 ` Richard Sandiford
2018-08-18 17:09 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1808071129010.30891@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).