From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101977 invoked by alias); 16 May 2019 12:38:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 101969 invoked by uid 89); 16 May 2019 12:38:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2049, felt, placed X-HELO: esa4.hgst.iphmx.com Received: from esa4.hgst.iphmx.com (HELO esa4.hgst.iphmx.com) (216.71.154.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 May 2019 12:38:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1558010296; x=1589546296; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=/C7M5KpUSZnX4pH72BKZfIKvjU4VPUmaV9GUsJoTkmI=; b=BKm7SqSBw5pzq2C/V+hem4r/gcPcCQcj4l+Gjr5ORaAhcYGFFvKDbram mzbLbR4tOlu+sI+dsPS7oKv0UiJZuR2lqarzgAKBp60qcC8QDJowKnNBs PvZu3tXT79/lpM3mAEIVOavH/TdGmUj0yJd3+I3M58EnTR0sj+4Tbi187 QM1xtvw1MvIx5f5eN4AsjCHqvxRGzloZEBU5Dvph9KqA9yQp1OhhZQYJs 6whdzaVCWBEIXAHhdHEXg1tFFeL8mh8JC+wFkjUo5kaF4tbVb/LbZPxF4 YTxPGl1OaF/Y/3Bcy0luPK/Aa23bUR+BehpkCVS8ltj2HEidMZOpdG9gU Q==; Received: from mail-by2nam03lp2050.outbound.protection.outlook.com (HELO NAM03-BY2-obe.outbound.protection.outlook.com) ([104.47.42.50]) by ob1.hgst.iphmx.com with ESMTP; 16 May 2019 20:38:14 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K9QegjAEwr8Kj9iLfdKMsAQZSvQz7JLF6O7GkCOg9tA=; b=kTIWvtRGIhsnVT/XnSopLs3r9qvvtoMi0jDY6b+Om2MtLpJUq+7aLaoP/vm/grP39k9ySauLnnAVSlR7z8hSAKG/kOihcKNW0Vrj19cDpBTevJ1/br72npARYCeM9DJXgQ8ZK50ukM3NoqsY7JSGWhOTgSUdHy5tdd6oqRly7M8= Received: from BYAPR04MB6262.namprd04.prod.outlook.com (20.178.235.160) by BYAPR04MB5670.namprd04.prod.outlook.com (20.179.57.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Thu, 16 May 2019 12:38:12 +0000 Received: from BYAPR04MB6262.namprd04.prod.outlook.com ([fe80::31ee:c691:33ca:b46b]) by BYAPR04MB6262.namprd04.prod.outlook.com ([fe80::31ee:c691:33ca:b46b%3]) with mapi id 15.20.1878.028; Thu, 16 May 2019 12:38:12 +0000 From: "Maciej W. Rozycki" To: Jacob Bachmeyer CC: "gcc-patches@gcc.gnu.org" , "dejagnu@gnu.org" , Pierre-Marie de Rodat , Arnaud Charlet , Eric Botcazou Subject: Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation Date: Thu, 16 May 2019 12:38:00 -0000 Message-ID: References: <5CDC9CDF.8070105@gmail.com> In-Reply-To: <5CDC9CDF.8070105@gmail.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=macro@wdc.com; wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="us-ascii" Content-ID: <456A2B5B241E8545949573982D85EBA7@namprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-SW-Source: 2019-05/txt/msg00946.txt.bz2 On Wed, 15 May 2019, Jacob Bachmeyer wrote: > > Index: gcc/gcc/testsuite/lib/gnat.exp > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- gcc.orig/gcc/testsuite/lib/gnat.exp > > +++ gcc/gcc/testsuite/lib/gnat.exp > > @@ -167,6 +167,8 @@ proc gnat_target_compile { source dest t > > set options [concat "additional_flags=3D$TOOL_OPTIONS" $options] > > } > >=20=20 > > + set options [concat "{ada}" $options] > > + > > return [target_compile $source $dest $type $options] > > } > >=20=20=20 > Your Tcl syntax looks suspicious to me. Is there a reason for "ada" to=20 > be in both double quotes and braces? Most existing `options' elements are lists, as shown by: clone_output "options: $options\n" placed at the top of `default_target_compile' (leading paths stripped=20 here): options: {ada} {additional_flags=3D-fno-diagnostics-show-caret -fno-diagnos= tics-show-line-numbers -fdiagnostics-color=3Dnever --sysroot=3D.../sysroot}= {additional_flags=3D-gnatJ -c -u} {compiler=3D.../gcc/gnatmake --GCC=3D...= /gcc/xgcc --GNATBIND=3D.../gcc/gnatbind --GNATLINK=3D.../gcc/gnatlink -carg= s -B.../gcc -largs --GCC=3D.../gcc/xgcc\ -B.../gcc\ -march=3Drv64imafdc\ -m= abi=3Dlp64d -margs --RTS=3D.../riscv64-linux-gnu/lib64/lp64d/libada -q -f} = timeout=3D300 so I did this for consistency, although in reality it doesn't matter, not=20 at least for `default_target_compile', and either approach would work. We are not consistent here in `gnat_target_compile' anyway, as you can=20 see from the two existing `concat' invocations, and also the `timeout=3D300= '=20 element. > Perhaps {lappend options ada} might be simpler? Is placing ada at the=20 > beginning of the list important? It can't be last because we override the default compiler otherwise selected by this option in `default_target_compile', and then options=20 passed in may override it further. Overall I felt it to be safer if we=20 placed the compiler type selection first rather than somewhere in the=20 middle. I hope it clears your concerns. Maciej