From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31413 invoked by alias); 3 Jun 2019 20:11:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31405 invoked by uid 89); 3 Jun 2019 20:11:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: esa6.hgst.iphmx.com Received: from esa6.hgst.iphmx.com (HELO esa6.hgst.iphmx.com) (216.71.154.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Jun 2019 20:10:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1559592660; x=1591128660; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=flOb5pQ/uKMP8mBQbN9XYIwymIe+E2WF48+TksEDwMc=; b=ICKERL0d97f5gPsiBtRDI5HUHcaLomUIxZQRJprZYMNbLgZKyhRGns4d Fv8JTcSBPdYj9AAmH4k1k6XWyPlKPpda/4hC8GBEl+4acbrVnCTArYImb 06Za9O0BeoK1sFTAqShJoJtqMditiTocNypqwGGw9qxzcZ4mY38UkFEvg Vtnzmr/mOkJ3/SRl77SsZYaAv8sGCGpxks+HAIOLBe9kXiOeMptwMBsa5 wJrcb//bBYcJK+0zTjuxRFrmqQCizyTpeX994zJF3yaAGm3wHpdGrJCS3 wmdUme7uPMSsUuyXSO3Mw5cus8pwW4ZLmjN0aLEIB8Fy7pPiJMMSEkWPZ g==; Received: from mail-co1nam03lp2059.outbound.protection.outlook.com (HELO NAM03-CO1-obe.outbound.protection.outlook.com) ([104.47.40.59]) by ob1.hgst.iphmx.com with ESMTP; 04 Jun 2019 04:10:58 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FMZbjpNtc4Q5qDGxkzx7zk4GpMeBibRswx9+ySNaiN4=; b=lkD018lo/q2fntrMyxJM0ILfZ1uuZX/l3qQ1Lz5VmEHntQs1NX4OhVipjVnSulTCUAaIzeQzVk66ByXq/OppR0cixL1Y5IC1kcVyNaNZqsPnr94k/fyvSeVLQNy2qhXK966n9yuzVIbOWa14Stp5XXxi7Dl7bHdQel3/lgRIq4I= Received: from BYAPR04MB4502.namprd04.prod.outlook.com (52.135.238.11) by BYAPR04MB5413.namprd04.prod.outlook.com (20.178.50.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.18; Mon, 3 Jun 2019 20:10:56 +0000 Received: from BYAPR04MB4502.namprd04.prod.outlook.com ([fe80::e15b:4e75:ab6c:8e1a]) by BYAPR04MB4502.namprd04.prod.outlook.com ([fe80::e15b:4e75:ab6c:8e1a%6]) with mapi id 15.20.1943.018; Mon, 3 Jun 2019 20:10:56 +0000 From: Maciej Rozycki To: Ian Lance Taylor CC: Jim Wilson , Andreas Schwab , gcc-patches , gofrontend-dev Subject: Re: Go patch committed: Intrinsify runtime/internal/atomic functions Date: Mon, 03 Jun 2019 20:11:00 -0000 Message-ID: References: <87a7fibpms.fsf@igel.home> <87zhn395ix.fsf@igel.home> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=macro@wdc.com; wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: macro@wdc.com X-SW-Source: 2019-06/txt/msg00112.txt.bz2 On Mon, 3 Jun 2019, Ian Lance Taylor wrote: > > I have results as at r270765, taken with QEMU run in the user emulation > > mode (I have patches outstanding for configury/Makefiles to correctly > > support libgo and other library testing with a build sysroot in such a > > setup, pending the completion of my WDC copyright assignment paperwork > > with FSF): > > > > FAIL: go.test/test/args.go execution, -O2 -g >=20 > That is a fairly trivial test so if that one fails then something is > pretty fundamentally wrong somewhere. >=20 > You can run just that test by running >=20 > make RUNTESTFLAGS=3Dgo-test.exp=3Dargs.go check-gcc-go >=20 > If it fails you should have an executable gcc/testsuite/go/args.x. The .log file reports (leading paths edited throughout): spawn qemu-riscv64 -E LD_LIBRARY_PATH=3D.:.../riscv64-linux-gnu/lib64/lp64d= /libgo/.libs:.../gcc:.../gcc/lib64/lp64:.../gcc/lib64/lp64d .../gcc/testsui= te/go/args.x panic: argc goroutine 1 [running]: main.main .../gcc/testsuite/go.test/test/args.go:18 FAIL: go.test/test/args.go execution, -O2 -g The same happens when this is invoked manually. > Run that executable as `args.x arg1 arg2`. That works however. I've modified `sim_spawn', which is declared as: proc sim_spawn { dest cmdline args } by adding this line: clone_output "sim_spawn $dest $cmdline $args" and it reports no command-line arguments being passed to the test case=20 from the test harness: sim_spawn qemu-user-lp64d .../gcc/testsuite/go/args.x so I gather there is something wrong at an upper level. I'll see if I can= =20 investigate it at one point, but given that it is probably the only test=20 case that expects arguments I consider it a very low priority issue.=20=20 Also not all simulators may support arguments in the first place,=20 especially for bare metal. NB I had to make a local copy of `sim_spawn' in the qemu-user-lp64d.exp=20 board description file used, to get `-E ...' passed to QEMU with the=20 LD_LIBRARY_PATH setting for uninstalled shared libraries to work. That=20 does not affect received `args' being empty however. Maciej