From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id 45A043857C4C for ; Wed, 3 Nov 2021 13:21:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 45A043857C4C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lj1-x233.google.com with SMTP id y8so3780519ljm.4 for ; Wed, 03 Nov 2021 06:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:user-agent:mime-version; bh=814SffNkI/saL7WfxYgAKHYdv4pjl1MVjmO/sdVcbsk=; b=MlnJ/ONAnCeoCViCgAD/gi7ZNEY3Axske4ehJsi/UVhvT+AIww64QYPqvcgCj6Xy0g d6GG7XGeVOaFb6FKgBUm4OWyFvoOpKR2L78GiE0yQYu/q+UkF44jSXqJ6QSe0HdHMgzq 5b6z+fp64qgyTBxpJCkDrpd/mOlu4z87n98bIPZ99zr2VYpQ+ncEzKMbY2UADWoBNzuV +BLiHY5pfuueeDvC6VDe4s13BY68Jn5NI38CgfsWPakypp2PMaMZ9ciRCAQ5usN/q0vx 0eP02T1tLeG5NiivteRp6WqjVh8rS8zducKU0SfU2oAN+eDlzxuEc2QPKajjAKZEPlRj oSDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :mime-version; bh=814SffNkI/saL7WfxYgAKHYdv4pjl1MVjmO/sdVcbsk=; b=v2bWxFRDaaH3+z08H3K5Lx/sgN/XSFvSGS4pgYT+umnpaf0aWFE6Ihqtv38kjncmB2 Dt90TR5j66wxLKrK6Le89GI0Y2mu9juAT2Wtk6iJmv8bd2cemO208wHNij9XrfVAI9oC pyDztr5p3MnduqaUDVcgNU6teKqpawM75qQhIxh8GLeNgHgEjVl5LpyfiYtjbddm59iT zGckQMnxfb+el+FZOdCFpv+n4iORVFgWbqBz4mW0T7mswDxD5psGxp+ZndAltN8e+sBt dhMTRDSvw0JvAWAMQ6h4E3oGhFg59+M8EkTeabNtK2vFfuFtg0xnytlPjAqi5WV+LtrG yEww== X-Gm-Message-State: AOAM532Ba4HYf2HVUlSGG/l32L7UQ51hAcim6q1EqMv7mWduY6WxUrSB DHFgR0tVx2Vk90hn5k78jYtwecV2Dl9f4g== X-Google-Smtp-Source: ABdhPJzvIqBS+1hbXx4oFXanSHBwPkKWApvJUe0HEEBqh8RtwUtnbN+x1ZVNpIP8tgcGy4CxhjkV3A== X-Received: by 2002:adf:ebd0:: with SMTP id v16mr54680186wrn.291.1635939306567; Wed, 03 Nov 2021 04:35:06 -0700 (PDT) Received: from [192.168.0.201] ([212.69.42.53]) by smtp.gmail.com with ESMTPSA id l11sm1668594wrp.61.2021.11.03.04.35.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Nov 2021 04:35:06 -0700 (PDT) Date: Wed, 3 Nov 2021 11:35:04 +0000 (GMT) From: "Maciej W. Rozycki" To: gcc-patches@gcc.gnu.org Subject: [PATCH][GCC 11] ranger: Fix `-Werror' build error with `ranger_cache::push_poor_value' Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2021 13:21:22 -0000 Remove a commit 86534c07a390 ("Disable poor value processing in ranger cache.") regression that caused GCC not to build anymore if `-Werror' has been enabled: .../gcc/gimple-range-cache.cc: In member function 'bool ranger_cache::push_poor_value(basic_block, tree)': .../gcc/gimple-range-cache.cc:850:44: error: unused parameter 'bb' [-Werror=unused-parameter] 850 | ranger_cache::push_poor_value (basic_block bb, tree name) | ~~~~~~~~~~~~^~ .../gcc/gimple-range-cache.cc:850:53: error: unused parameter 'name' [-Werror=unused-parameter] 850 | ranger_cache::push_poor_value (basic_block bb, tree name) | ~~~~~^~~~ To keep the change to the minimum mark the parameters reported unused. gcc/ * gimple-range-cache.cc (ranger_cache::push_poor_value): Mark parameters unused. --- Hi, Probably obvious, OK to apply? [It's been a while since the offending commit; I guess nobody configures release branches with `--enable-werror-always'?] Maciej --- gcc/gimple-range-cache.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) gcc-ranger-cache-push-poor-value-unused.diff Index: gcc/gcc/gimple-range-cache.cc =================================================================== --- gcc.orig/gcc/gimple-range-cache.cc +++ gcc/gcc/gimple-range-cache.cc @@ -847,7 +847,8 @@ ranger_cache::register_dependency (tree // the request is actually made (ie, isn't a duplicate). bool -ranger_cache::push_poor_value (basic_block bb, tree name) +ranger_cache::push_poor_value (basic_block bb ATTRIBUTE_UNUSED, + tree name ATTRIBUTE_UNUSED) { // Disable poor value processing for GCC 11. It has been disabled in GCC 12 // as adding too much churn/compile time for too little benefit.