From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id A16743858401 for ; Mon, 8 Nov 2021 10:00:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A16743858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x32d.google.com with SMTP id b184-20020a1c1bc1000000b0033140bf8dd5so11147069wmb.5 for ; Mon, 08 Nov 2021 02:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=9AnOJReQ3J/YhGmNY5jCmCi2MCFAvusCqGYMOPkShLA=; b=IdrEpw6WDCPnbhY6vd7xqJ6inmKXqN7TNh9zaZInmKUE3yBfBjidOsQZzzSRA52EKU nUpRQv6MaUyQDAHieFvi12raj5v3pVjxzR+No7sDyvch769jJM8Jb1CRe3SjoSdFVSDC ebRrZ+U1QUzVSwBKyEgsKhCnaL9Stnju0Q/eqCaDvWMH0Ok8DJalFZKoifkZlp0YlFel iuV3TBmKzSWMLTy1NtaddEFnP9e+7pnZv4B3yYTz23rSwNTnZd4VsI15IjkGWZ2eK4bc uxmC68sWHlp1QqWodsbQHPTb1FqBxvhcPpvkAHuhyIbgaT7r/0mqR2oIBYabjl3+v2Bc 3vpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=9AnOJReQ3J/YhGmNY5jCmCi2MCFAvusCqGYMOPkShLA=; b=Ei1vESQHjt45epY+i9Zup1ydVV2hM4NdRFUPQBocwiEZlr/+N8x4Ryglu1hmfvl6bf HiITHwfa7YjjJj6hcAMNbzmLw7Y/ZXGmmu1P9hlMcN/D3T/G9DIRZiwJ37ldWLXBatRy JfdfnmBIdQuwesn3+5kP8Hm3A+cT8qBOX4BRbr967tR2OJWggXeW94gJDsJuu1CO4Dsl 39C3M05fBnS0oPMyoZVAoV9wceGWWT2PYEZD61Z58shafa5pHRV+7Bu74M7r0k5zstTA raaum2+26pJbrmAKJElwdjd1wl05D8bKbq+6r+HpGjn/ZVX7gKkCbC2u4Im7vxQSl6KM 73fg== X-Gm-Message-State: AOAM5317A6UDBlYF5oOmVe26lotF3/GbE/238kjxXmKYYpeiYSrtwDGw ZGZKgJgG0xwU+K2zkYG4CJC2CA== X-Google-Smtp-Source: ABdhPJxj2VgH9Ac5yGadOh0Bcflk7Y9UnboCLoxC14k/sokTB98AZ7So5XibWbvRf6GFwYfmTVrOOQ== X-Received: by 2002:a05:600c:1ca4:: with SMTP id k36mr41712584wms.169.1636365625716; Mon, 08 Nov 2021 02:00:25 -0800 (PST) Received: from tpp.orcam.me.uk (tpp.orcam.me.uk. [2001:8b0:154:0:ea6a:64ff:fe24:f2fc]) by smtp.gmail.com with ESMTPSA id z8sm16931262wrh.54.2021.11.08.02.00.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Nov 2021 02:00:25 -0800 (PST) Date: Mon, 8 Nov 2021 10:00:24 +0000 (GMT) From: "Maciej W. Rozycki" To: Hans-Peter Nilsson cc: gcc-patches@gcc.gnu.org, Ulrich Weigand Subject: Re: [PATCH] PR middle-end/103059: reload: Also accept ASHIFT with indexed addressing In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 10:00:28 -0000 On Sun, 7 Nov 2021, Hans-Peter Nilsson wrote: > > How do I run regression-testing with this target however? I can see QEMU > > support upstream, even for user-mode Linux, which would be the easiest to > > run (sadly toolchain support for CRIS/Linux was removed a while ago as was > > the Linux kernel port; at one point I even considered getting myself a > > CRIS development board as an alternative RISC platform that would Linux, > > but concluded that it was too expensive for the features it offered), but > > for a bare metal environment both a C library (newlib?) and then a > > specific board support package is required. > > Classic "bare-metal" whatever-elf testing should not be a > stranger: sim and binutils support are in place in the official > binutils+gdb git, as is newlib in that git and since many > dejagnu releases a cris-sim.exp baseboard file. Just build and > install binutils and sim for cris-elf (can probable be done at > the same time/same builds from a binutils-and-gdb checkout, but > separate builds are sometimes necessary) then build and test gcc > from a combined-source-tree containing newlib and gcc. > (Instructions for combining trees may be salvaged from the > rottening https://gcc.gnu.org/simtest-howto.html but actually I > roll tarballs and untar gcc over an (untarred) newlib tree.) Thanks, I'll give it a try. I don't use GNUsim-based configurations very often, so I'm not even used to thinking they exist. It might be good to have a template build configuration then. > > Or may I ask you to put this patch through testing with your environment? > > Where's the fun in that? :) > (I thought you'd use 6cb68940dcf9 and do the same for VAX.) I could, easily, but being confined to gcc/config/cris I don't expect it to be included in the build let alone trigger anything. > > > Your proposed patch reminded me of 6cb68940dcf9; giving reload a > > > reload-specific insn_and_split pattern to play with, matching > > > "mult" outside of a mem. I *guess* that's the CRIS-specific > > > replacement to c605a8bf9270. > > > > Possibly, except for the missing reload bits making it incomplete. > > No, my thinking was that it wouldn't be needed. But, I didn't > have a close look and maybe the problem isn't exactly the same > or VAX has additional caveats. Also, that reload-pacifying > pattern *is* a target-specific workaround for a reload bug, but > a risk-free one for other targets. Right. > brgds, H-P > PS. I'll fire up a round with that patch "tomorrow". Film at 11. Great, thanks! I'll build and test your configuration anyway. Though I can see that CRIS has LRA wired to off right now, which means there'll be little interference likely from my upcoming work with the VAX port as I'm going to focus on making LRA better now rather than poking at old reload unless something else as grave as this issue pops up. Maciej